Skip to content

resolve: Identifier resolution refactorings #149454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Nov 29, 2025
Merged

resolve: Identifier resolution refactorings #149454

merged 9 commits into from
Nov 29, 2025

Conversation

@petrochenkov
Copy link
Contributor

@petrochenkov petrochenkov commented Nov 29, 2025

Mostly splitting large functions into smaller functions, including some parts from #144131, there should be no functional changes.
See individual commits.

@petrochenkov
resolve: Use ControlFlow in fn visit_scopes callback
97e6819
@petrochenkov
resolve: Move one iteration of resolve_ident_in_scope_set into a se…
6ca6302 
…parate function
@petrochenkov
resolve: Move ambiguity detection in resolve_ident_in_scope_set int…
47edfd3 
…o a separate function
@petrochenkov
resolve: Tweak top level logic and comments in `resolve_ident_in_scop…
621d870 
…e_set`
@petrochenkov
resolve: Move resolve_ident_in_module_unadjusted for real modules t…
b7f6c95 
…o a separate method
@petrochenkov
resolve: Remove some function parameters and return values that are n…
56e1e24 
…o longer used
@petrochenkov
resolve: Replace enum Weak with ops::ControlFlow
674d287
@petrochenkov
resolve: Correctly mark break and continue for determinate errors
9761db0 
Existing but private bindings - break, everything else - continue.
@petrochenkov
resolve: Split resolve_ident_in_module_unadjusted into two parts - …
c91b6ca 
…for non-glob and glob bindings.

In preparation for introducing `Scope::Module(Non)Globs` and `ScopeSet::Module`.
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 29, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 29, 2025

r? @eholk

rustbot has assigned @eholk.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@petrochenkov petrochenkov mentioned this pull request Nov 29, 2025
Open
@eholk
Copy link
Contributor

eholk commented Nov 29, 2025

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 29, 2025

📌 Commit c91b6ca has been approved by eholk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 29, 2025
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 29, 2025
Merged
bors added a commit that referenced this pull request Nov 29, 2025
@bors
Auto merge of #149462 - matthiaskrgr:rollup-vfwin7f, r=matthiaskrgr
3ff30e7 
Rollup of 3 pull requests

Successful merges:

 - #148746 (const validation: remove check for mutable refs in final value of const)
 - #148765 (std: split up the `thread` module)
 - #149454 (resolve: Identifier resolution refactorings)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b35b187 into rust-lang:main Nov 29, 2025
11 checks passed
rust-timer added a commit that referenced this pull request Nov 29, 2025
@rust-timer
Unrolled build for #149454
fad09d2 
Rollup merge of #149454 - petrochenkov:openapi0, r=eholk

resolve: Identifier resolution refactorings

Mostly splitting large functions into smaller functions, including some parts from #144131, there should be no functional changes.
See individual commits.
@rustbot rustbot added this to the 1.93.0 milestone Nov 29, 2025
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Nov 30, 2025
@bors
Auto merge of #149462 - matthiaskrgr:rollup-vfwin7f, r=matthiaskrgr
4287fab 
Rollup of 3 pull requests

Successful merges:

 - rust-lang/rust#148746 (const validation: remove check for mutable refs in final value of const)
 - rust-lang/rust#148765 (std: split up the `thread` module)
 - rust-lang/rust#149454 (resolve: Identifier resolution refactorings)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@eholk eholk

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.93.0

Development

Successfully merging this pull request may close these issues.

4 participants

@petrochenkov @rustbot @eholk @bors