Skip to content

resolve: Identifier resolution refactorings #149454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Nov 29, 2025
Merged

resolve: Identifier resolution refactorings #149454

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
97e6819
resolve: Use `ControlFlow` in `fn visit_scopes` callback
petrochenkov Nov 27, 2025
6ca6302
resolve: Move one iteration of `resolve_ident_in_scope_set` into a se…
petrochenkov Nov 27, 2025
47edfd3
resolve: Move ambiguity detection in `resolve_ident_in_scope_set` int…
petrochenkov Nov 27, 2025
621d870
resolve: Tweak top level logic and comments in `resolve_ident_in_scop…
petrochenkov Nov 27, 2025
b7f6c95
resolve: Move `resolve_ident_in_module_unadjusted` for real modules t…
petrochenkov Nov 28, 2025
56e1e24
resolve: Remove some function parameters and return values that are n…
petrochenkov Nov 28, 2025
674d287
resolve: Replace `enum Weak` with `ops::ControlFlow`
petrochenkov Nov 29, 2025
9761db0
resolve: Correctly mark break and continue for determinate errors
petrochenkov Nov 29, 2025
c91b6ca
resolve: Split `resolve_ident_in_module_unadjusted` into two parts - …
petrochenkov Nov 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion compiler/rustc_resolve/src/diagnostics.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
use std::ops::ControlFlow;

use itertools::Itertools as _;
use rustc_ast::visit::{self, Visitor};
use rustc_ast::{
Expand Down Expand Up @@ -1261,7 +1263,7 @@ impl<'ra, 'tcx> Resolver<'ra, 'tcx> {
}
}

None::<()>
ControlFlow::<()>::Continue(())
});
}

Expand Down
Loading
Loading