std: use a mutex for ThreadId generation if available
#149476
+27
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
Collaborator
|
rustbot has assigned @Mark-Simulacrum. Use |
joboet
commented
Nov 30, 2025
| #[cold] | ||
| fn exhausted() -> ! { | ||
| panic!("failed to generate unique thread ID: bitspace exhausted") | ||
| rtabort!("failed to generate unique thread ID: bitspace exhausted") |
Member
Author
There was a problem hiding this comment.
Panicking may allocate, so it shouldn't be used here either.
Contributor
|
This violates the contract we established that the global allocator may call So if there's a platform without 64-bit atomics but which has an allocating |
Member
Author
No it won't, the |
Contributor
|
@joboet Actually, re-reading the code, neither If we were to adopt #147342 I think we might be able to get rid of the desperate path altogether. |
Member
Author
The problem is that not all threads are spawned by Rust – and on foreign threads, it's the first call to |
Contributor
|
I hadn't considered foreign threads, you're right. |
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Member
|
This still invokes |
RalfJung
reviewed
Nov 30, 2025
| } | ||
| } | ||
|
|
||
| /// Generates a new unique thread ID. |
Member
There was a problem hiding this comment.
Suggested change
| /// Generates a new unique thread ID. | |
| /// Generates a new unique thread ID. Might use the global allocator. |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 30, 2025
ThreadId generation fallback path: avoid spurious yields Fixes rust-lang/miri#4737 Alternative to rust-lang#149476 Cc `@orlp` `@joboet`
bors
added a commit
that referenced
this pull request
Nov 30, 2025
ThreadId generation fallback path: avoid spurious yields Fixes rust-lang/miri#4737 Alternative to #149476 Cc `@orlp` `@joboet`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rust-lang/miri#4737
#144465 changed
ThreadId::newto use a spinlock on platforms without 64-bit atomics. This introduces subtle scheduling changes such as the one described in rust-lang/miri#4737 and isn't ideal from a performance perspective either. The necessity of avoidingMutexis not always given however – it only needs to be avoided if the thread handle is lazily initialised. For normal Rust threads however,stdgenerates the thread id inside the spawning logic, where allocation is expected. Thus this PR renames the currentThreadId::newtodesperate_newand reintroduces a versionThreadId::newthat employs aMutexto synchronise access to the inner spin-lock.CC @RalfJung @orlp