-
Notifications
You must be signed in to change notification settings - Fork 14.1k
std: use a mutex for ThreadId generation if available
#149476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
joboet
wants to merge
1
commit into
rust-lang:main
Choose a base branch
from
joboet:synchronized-threadid-new
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+27
−4
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -31,11 +31,15 @@ use crate::sync::atomic::{Atomic, Ordering}; | |||||
| pub struct ThreadId(NonZero<u64>); | ||||||
|
|
||||||
| impl ThreadId { | ||||||
| // Generate a new unique thread ID. | ||||||
| pub(crate) fn new() -> ThreadId { | ||||||
| /// Generates a new unique thread ID, and does not rely on the global | ||||||
| /// allocator. | ||||||
| /// | ||||||
| /// This should only be used in contexts where a new `ThreadId` is | ||||||
| /// desperately required, but the global allocator might not be available. | ||||||
| pub(super) fn desperate_new() -> ThreadId { | ||||||
| #[cold] | ||||||
| fn exhausted() -> ! { | ||||||
| panic!("failed to generate unique thread ID: bitspace exhausted") | ||||||
| rtabort!("failed to generate unique thread ID: bitspace exhausted") | ||||||
| } | ||||||
|
|
||||||
| cfg_select! { | ||||||
|
|
@@ -96,6 +100,25 @@ impl ThreadId { | |||||
| } | ||||||
| } | ||||||
|
|
||||||
| /// Generates a new unique thread ID. | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| pub(crate) fn new() -> ThreadId { | ||||||
| cfg_select! { | ||||||
| target_has_atomic = "64" => { | ||||||
| // The generation is implemented lock-free anyway. | ||||||
| ThreadId::desperate_new() | ||||||
| } | ||||||
| _ => { | ||||||
| // Synchronize the id generation – `Mutex` has better | ||||||
| // synchronization behaviour than the spinlock used in | ||||||
| // `desperate_new`, but might need allocation. | ||||||
| use crate::sync::nonpoison::Mutex; | ||||||
| static LOCK: Mutex<()> = Mutex::new(()); | ||||||
| let _guard = LOCK.lock(); | ||||||
| ThreadId::desperate_new() | ||||||
| } | ||||||
| } | ||||||
| } | ||||||
|
|
||||||
| #[cfg(any(not(target_thread_local), target_has_atomic = "64"))] | ||||||
| pub(super) fn from_u64(v: u64) -> Option<ThreadId> { | ||||||
| NonZero::new(v).map(ThreadId) | ||||||
|
|
||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Panicking may allocate, so it shouldn't be used here either.