-
Notifications
You must be signed in to change notification settings - Fork 14.1k
Revert #149516 to fix i686-pc-windows-gnu host #149600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Revert rust-lang#149516 because it caused dist to pick up x86_64 `libwinpthreads.dll` dependency, resulting in broken toolchain.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This revert looks good to me (except issue link in commit). It just rolls back to what was already working. Do you want a specific review from Jieyou?
|
Thanks. Regarding the commit message, I asked about it in #145456 (comment) and the response was to keep it. Increasing priority per https://forge.rust-lang.org/compiler/reviews.html#priority @bors p=5 (It can be included in rollups) |
|
The toolchain is broken so we should get this in, @bors r=Kivooeo,tgross35 If you get the chance, it would be nice to add this bit to the message: (assuming that's the right commit) which is part of what git does automatically and in the rustc-dev-guide. Just to avoid digging up the PR to see which commit got undone. |
Revert #149516 because it caused dist to pick up x86_64
libwinpthreads.dlldependency, resulting in broken toolchain.Note, I didn't use the procedure explained at: https://forge.rust-lang.org/compiler/reviews.html#reverts because the revert button isn't there.
This reverts commit 5afd8ff, reversing
changes made to 7cb02f9.