rust-analyzer subtree update
#149602
Merged
rust-analyzer subtree update
#149602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't need it anymore; `ParamEnv` is enough. A lot of code relied on getting the crate from the `TraitEnvironment`. Some had it readily available from other sources, some changed to take a new struct `ParamEnvAndCrate`.
rustdoc has a separate environment variable for banning warnings, so set that in the GitHub action configuration. rust-lang/cargo#8424 (comment) Fix all the rustdoc warnings on unknown types or functions. I've updated references wherever it's obvious, otherwise I've replaced the rustdoc link with plain backticks. There were also some cases where rustdoc links referred to private APIs. I've disabled the rustdoc private API warning in those crates.
Previously, rust-analyzer would drop discover requests that arrived before we'd finished processing the previous request. Fix this by allowing multiple discover requests to be active. Keep track of the number of discover operations for the quiescence check, and keep the process handles until they terminate.
Now that there's a table of contents rendered in the left sidebar, there doesn't seem to be much value in rendering a table of contents on the page too. The sidebar TOC was added in mdbook 0.5: https://github.com/rust-lang/mdBook/blob/master/CHANGELOG.md#05-migration-guide
internal: Remove `TraitEnvironment`
fix(spelling): underling -> underlying
internal: Remove mdbook-toc usage
minor: Use 'deferred task' terminology consistently
Fix rustdoc warnings and add CI
…uests fix: Allow multiple discover operations
Simplify the code a bit.
…display minor: Introduce a type alias for `HirDisplay`'s `Result`
Example
---
```rust
fn main() {
let x = &$0
}
```
**Before this PR**
```rust
fn main() {
let x = &loop {
$0
}
}
```
**After this PR**
```rust
fn main() {
let x = &loop {
$0
};
}
```
…t-semi Fix nested expr missing semicolon in incomplete-let
fix: More proc-macro-srv proto fixes
Collaborator
|
rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead. cc @rust-lang/rust-analyzer |
rustbot
added
S-waiting-on-review
Member
Author
|
@bors r+ p=2 rollup=always |
Collaborator
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 5325015 (parent) -> 556beb9 (this PR) Test differencesShow 4 test diffs4 doctest diffs were found. These are ignored, as they are noisy. Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 556beb9ec72360512d0294eb0855c92fb2c20c88 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Collaborator
|
Finished benchmarking commit (556beb9): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (secondary 2.2%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary 0.9%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 469.794s -> 468.789s (-0.21%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subtree update of
rust-analyzerto rust-lang/rust-analyzer@633cff2.Created using https://github.com/rust-lang/josh-sync.
r? @ghost