Rollup of 10 pull requests #149632
Merged
Rollup of 10 pull requests #149632
+575
−488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed_to_constitute_read_for_never` to more accessible locations
...wrt `type_ascribe`/unsafe binders -- the check was infinitely recursive before.
... since unreachable-code only has a few tests while `reachable` is the more popular directory...
[PR 148765](rust-lang#148765) changed the expected signature of Thread::new(), which broke Motor OS target. Also set thread name.
tests/ui/issues/issue-4935 is duplicated of tests/ui/argument-suggestions/suggest-better-removing-issue-126246.rs
`tests/ui/type-inference/ambiguous-num-type-method-call.rs`
`tests/ui/mismatched_types/assignment-mismatch-various-types.rs` merge `tests/ui/mismatched_types/main.rs`
This reverts commit 699184b.
This reverts commit f201752.
This register is only supported on the *powerpc*spe targets. It is only recognized by LLVM. gcc does not accept this as a clobber, nor does it support these targets. This is a volatile register, thus it is included with clobber_abi.
`vis_span.to(ident.span.shrink_to_lo())`
Improve `io::Error::downcast` Rewrite this function to help to compiler understand what is going on here.
Only apply `no_mangle_const_items`'s suggestion to plain const items resolve: rust-lang#149511
…h726 fix the check for which expressions read never type Fixes rust-lang#149542 Fixes rust-lang#149431 First commit is a drive-by needed for the refactor of the unreachable code lint, see rust-lang#148303
…, r=ehuss rename cortex-ar references to unified aarch32 Just a little documentation update. Thanks to the amazing work of `@thejpster` , we have a unified `aarch32-rt` run-time for both Cortex-A and Cortex-R.
Batched compiletest Config fixups A few batched `compiletest` `Config` self-consistency fixups, mostly to get it out of the way for follow-up changes I would like to make (namely, I would like to slightly cleanup the config parsing logic). ### Review remarks Changes are best reviewed commit-by-commit. This PR should contain no functional changes. r? `@Zalathar` (or bootstrap/compiler)
…anieu Allow PowerPC spe_acc as clobber-only register This register is only supported on the *powerpc*spe targets. It is only recognized by LLVM. gcc does not accept this as a clobber, nor does it support these targets. This is a volatile register, thus it is included with clobber_abi. r? `@Amanieu` r? `@antoyo`
…h, r=Mark-Simulacrum
Implement benchmarks for uN::{gather,scatter}_bits
Feature gate: #![feature(uint_gather_scatter_bits)]
Tracking issue: rust-lang#149069
Accepted ACP: rust-lang/libs-team#695 (comment)
For each method, there are three benchmarks, which differ in that the mask (second) argument is one of:
- constant at compile time
- runtime value but invariant for the measured loop
- different for each call
Sample output
```text
num::int_bits::u32::constant::gather_bits 555.82ns/iter +/- 22.41
num::int_bits::u32::constant::scatter_bits 545.45ns/iter +/- 124.26
num::int_bits::u32::invariant::gather_bits 8178.86ns/iter +/- 217.37
num::int_bits::u32::invariant::scatter_bits 7135.95ns/iter +/- 214.51
num::int_bits::u32::variable::gather_bits 10539.29ns/iter +/- 198.90
num::int_bits::u32::variable::scatter_bits 9671.26ns/iter +/- 254.88
```
(and similarly for the other `uN` types)
rustbot
added
A-compiletest
Member
Author
|
@bors try jobs=x86_64-msvc-1,i686-msvc-1,x86_64-mingw-1,test-various,armhf-gnu,aarch64-apple,x86_64-gnu-llvm-20-3 |
This comment has been minimized.
This comment has been minimized.
rust-bors bot
added a commit
that referenced
this pull request
Dec 4, 2025
Rollup of 10 pull requests try-job: x86_64-msvc-1 try-job: i686-msvc-1 try-job: x86_64-mingw-1 try-job: test-various try-job: armhf-gnu try-job: aarch64-apple try-job: x86_64-gnu-llvm-20-3
Member
Author
|
@bors r+ rollup=never p=5 |
Collaborator
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 5372fc9 (parent) -> 29e035e (this PR) Test differencesShow 192 test diffsStage 1
Stage 2
Additionally, 98 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 29e035e1728488dce5a03daa527ab1091d1cda47 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Collaborator
|
📌 Perf builds for each rolled up PR:
previous master: 5372fc9cb7 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
Collaborator
|
Finished benchmarking commit (29e035e): comparison URL. Overall result: ❌✅ regressions and improvements - no action needed@rustbot label: -perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary 0.2%, secondary 0.5%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary 3.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 468.725s -> 470.646s (0.41%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
io::Error::downcast#149521 (Improveio::Error::downcast)no_mangle_const_items's suggestion to plain const items #149544 (Only applyno_mangle_const_items's suggestion to plain const items)tests/ui/issuestests [2/N] #149595 (Tidying uptests/ui/issuestests [2/N])Iterator::{exactly_one, collect_array}" #149597 (Revert "implement and testIterator::{exactly_one, collect_array}")r? @ghost
@rustbot modify labels: rollup
Create a similar rollup