Add a regression test for issue 145748 #149824
Merged
+16
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
Collaborator
|
rustbot has assigned @JonathanBrouwer. Use |
ShoyuVanilla
commented
Dec 10, 2025
| //@ edition:2021 | ||
|
|
||
| // Regression test for #129865. | ||
|
|
Member
Author
There was a problem hiding this comment.
Added a comment for pointing the issue as said in #149421 (comment)
Member
|
Can you please replace issue numbers with links, so it will be easier anytime in future to follow them by just copy paste |
ShoyuVanilla
force-pushed
the
issue-145748
branch
from
cb09665 to
d440210
Compare
Member
Author
Sure, done! |
Member
|
Thanks r=me once CI is green (will delegate just in case) @bors delegate+ |
Collaborator
|
✌️ @ShoyuVanilla, you can now approve this pull request! If @Kivooeo told you to " |
Member
Author
Collaborator
bors
added
S-waiting-on-bors
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Dec 10, 2025
Add a regression test for issue 145748 Seems to be fixed while allowing non-defining usages of opaques in next-solver. Closes rust-lang#145748
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Dec 10, 2025
Add a regression test for issue 145748 Seems to be fixed while allowing non-defining usages of opaques in next-solver. Closes rust-lang#145748
bors
added a commit
that referenced
this pull request
Dec 10, 2025
Rollup of 12 pull requests Successful merges: - #147602 (Deduplicate higher-ranked lifetime capture errors in impl Trait) - #147725 (Remove -Zoom=panic) - #148294 (callconv: fix mips64 aggregate argument passing for C FFI) - #148491 ( Correctly provide suggestions when encountering `async fn` with a `dyn Trait` return type) - #149417 (tidy: Detect outdated workspaces in workspace list) - #149458 (Run clippy on cg_gcc in CI) - #149679 (Restrict spe_acc to PowerPC SPE targets) - #149781 (Don't suggest wrapping attr in unsafe if it may come from proc macro) - #149795 (Use `let`...`else` instead of `match foo { ... _ => return };` and `if let ... else return` in std) - #149816 (Make typo in field and name suggestions verbose) - #149824 (Add a regression test for issue 145748) - #149826 (compiletest: tidy up `adb_path`/`adb_test_dir` handling) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
that referenced
this pull request
Dec 10, 2025
Rollup of 10 pull requests Successful merges: - #147725 (Remove -Zoom=panic) - #148294 (callconv: fix mips64 aggregate argument passing for C FFI) - #148491 ( Correctly provide suggestions when encountering `async fn` with a `dyn Trait` return type) - #149458 (Run clippy on cg_gcc in CI) - #149679 (Restrict spe_acc to PowerPC SPE targets) - #149781 (Don't suggest wrapping attr in unsafe if it may come from proc macro) - #149795 (Use `let`...`else` instead of `match foo { ... _ => return };` and `if let ... else return` in std) - #149816 (Make typo in field and name suggestions verbose) - #149824 (Add a regression test for issue 145748) - #149826 (compiletest: tidy up `adb_path`/`adb_test_dir` handling) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems to be fixed while allowing non-defining usages of opaques in next-solver.
Closes #145748