Use the embeddable filename for coverage artifacts #150036
Merged
+14
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Some changes occurred in coverage instrumentation. cc @Zalathar |
rustbot
added
A-LLVM
Member
|
I don't love the extra complexity here, since compiler path handling is already mysterious to me, but given the regression I'm OK with taking this as a spot fix for now. @bors r+ |
Collaborator
bors
added
S-waiting-on-bors
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Dec 16, 2025
…=Zalathar Use the embeddable filename for coverage artifacts Like debuginfo, coverage artifacts should use the embeddable path (aka absolute path). Unfortunately due to `coverage-run` and `compiletest`, I'm unable to create a reproducer in our test-suite, but when manually invoking `rustc` with the reproducer (rust-lang#150020 (comment)) I think the issue is fixed. Fixes rust-lang#150020 r? Zalathar
Member
Would a run-make test be able to help you out here? |
bors
added a commit
that referenced
this pull request
Dec 16, 2025
Rollup of 14 pull requests Successful merges: - #148756 (Warn on codegen attributes on required trait methods) - #148790 (Add new Tier-3 target: riscv64im-unknown-none-elf) - #149271 (feat: dlopen Enzyme) - #149459 (std: sys: fs: uefi: Implement set_times and set_perm) - #149771 (bootstrap readme: make easy to read when editor wrapping is not enabled) - #149856 (Provide an extended framework for type visit, for use in rust-analyzer) - #149950 (Simplify how inline asm handles `MaybeUninit`) - #150014 (Metadata loader cleanups) - #150021 (document that mpmc channels deliver an item to (at most) one receiver) - #150022 (Generate macro expansion for rust compiler crates docs) - #150029 (Update books) - #150031 (assert impossible branch is impossible) - #150034 (do not add `I-prioritize` when `F-*` labels are present) - #150036 (Use the embeddable filename for coverage artifacts) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
that referenced
this pull request
Dec 16, 2025
Rollup of 13 pull requests Successful merges: - #148756 (Warn on codegen attributes on required trait methods) - #148790 (Add new Tier-3 target: riscv64im-unknown-none-elf) - #149271 (feat: dlopen Enzyme) - #149459 (std: sys: fs: uefi: Implement set_times and set_perm) - #149771 (bootstrap readme: make easy to read when editor wrapping is not enabled) - #149856 (Provide an extended framework for type visit, for use in rust-analyzer) - #149950 (Simplify how inline asm handles `MaybeUninit`) - #150014 (Metadata loader cleanups) - #150021 (document that mpmc channels deliver an item to (at most) one receiver) - #150029 (Update books) - #150031 (assert impossible branch is impossible) - #150034 (do not add `I-prioritize` when `F-*` labels are present) - #150036 (Use the embeddable filename for coverage artifacts) r? `@ghost` `@rustbot` modify labels: rollup
Member
Author
I did this way since we already do it this way for the metadata, but I agree, this feels like implementation detail. We can probably add a helper function on |
Member
Author
I don't know, can run-make test invoke the |
Member
|
Ah, right, that would be tricky (ATM the answer is "no"). Please disregard. |
rust-timer
added a commit
that referenced
this pull request
Dec 16, 2025
Rollup merge of #150036 - Urgau:filenames-coverage-150020, r=Zalathar Use the embeddable filename for coverage artifacts Like debuginfo, coverage artifacts should use the embeddable path (aka absolute path). Unfortunately due to `coverage-run` and `compiletest`, I'm unable to create a reproducer in our test-suite, but when manually invoking `rustc` with the reproducer (#150020 (comment)) I think the issue is fixed. Fixes #150020 r? Zalathar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like debuginfo, coverage artifacts should use the embeddable path (aka absolute path).
Unfortunately due to
coverage-runandcompiletest, I'm unable to create a reproducer in our test-suite, but when manually invokingrustcwith the reproducer (#150020 (comment)) I think the issue is fixed.Fixes #150020
r? Zalathar