Rename dep node "fingerprints" to distinguish key and value hashes#152751
Open
Zalathar wants to merge 2 commits intorust-lang:mainfrom
Open
Rename dep node "fingerprints" to distinguish key and value hashes#152751Zalathar wants to merge 2 commits intorust-lang:mainfrom
Zalathar wants to merge 2 commits intorust-lang:mainfrom
Conversation
Member
Author
|
Contributor
|
☔ The latest upstream changes (presumably #152755) made this pull request unmergeable. Please resolve the merge conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the query system's dependency graph, each node is associated with two fingerprints: one that is typically a hash of the query key, and one that is typically a hash of the query's return value when called with that key.
Unfortunately, many identifiers and comments fail to clearly distinguish between these two kinds of fingerprint, which have very different roles in dependency tracking. This is a frequent source of confusion.
This PR therefore tries to establish a clear distinction between:
DepKind), and are typically a hash of the query keyThere should be no change to compiler behaviour.
r? nnethercote (or compiler)