Rollup of 6 pull requests#152755
Conversation
Unlike other systems, Windows requires runtime libraries to be present in `PATH` or right next to the binary. So, we copy the library next to the binary as the easier solution.
This struct was only wrapping `TyCtxt` in order to implement traits that were removed by RUST-152636. This commit also slightly simplifies the signature of `execute_job_incr`, by having it call `tcx.dep_graph.data()` internally.
The need for a `HasDepContext` impl on tuples can be avoided by passing the query vtable as part of an argument tuple instead.
Install LLVM DLL in the right place on Windows Continuation of rust-lang#151795 towards rust-lang#151774. Unlike other systems, Windows requires runtime libraries to be present in `PATH` or right next to the binary. So, we copy the library next to the binary as the easier solution. Tested building `rust-openssl` in debug and release modes, but the difference is within noise margin.
…lcnr `-Znext-solver` Remove the forced ambiguity hack from search graph As discussed in rust-lang/trait-system-refactor-initiative#257 r? lcnr
Remove `QueryCtxt` and trait `HasDepContext` - Follow-up to rust-lang#152636. - Potentially waiting on rust-lang#152703 to reduce conflicts. --- With the `QueryContext` trait removed, wrapper struct `QueryCtxt` no longer serves a purpose and can be replaced with `TyCtxt` everywhere. After that, the only obstacle to removing trait `HasDepContext` is `DepGraph::with_task`, which uses the trait to allow passing both a `TyCtxt` and a query vtable through the context argument. But we can achieve the same result by passing the vtable through the other argument instead, in a tuple alongside the query key. r? nnethercote
…enkov remove `#![allow(stable_features)]` from most tests The only remaining usages are tests that specifically deal with feature gates. This also deletes the very weird `#![feature(issue_5723_bootstrap)]`, a 13 year old "temporary fix" (rust-lang#5723).
Improve `VaList` stdlib docs tracking issue: rust-lang#44930 Some improvements to the `VaList` documentation, at least adding an example. We should link to the reference for c-variadic functions once stable. I've tried to call out explicitly that the type is meant for sending over the FFI boundary. r? workingjubilee cc @tgross35
…uillaumeGomez Update `sysinfo` version to `0.38.2` r? ghost
|
@bors r+ rollup=never p=5 |
This comment has been minimized.
This comment has been minimized.
|
📌 Perf builds for each rolled up PR:
previous master: 3f6250a7bb In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 3f6250a (parent) -> dfbfbf7 (this PR) Test differencesShow 6 test diffsStage 1
Stage 2
Additionally, 4 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard dfbfbf785f46d10103e80735a9ccb4765bd6dfe2 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
Finished benchmarking commit (dfbfbf7): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary -2.5%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary -1.4%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 480.825s -> 482.346s (0.32%) |
Successful merges:
-Znext-solverRemove the forced ambiguity hack from search graph #149904 (-Znext-solverRemove the forced ambiguity hack from search graph)QueryCtxtand traitHasDepContext#152704 (RemoveQueryCtxtand traitHasDepContext)#![allow(stable_features)]from most tests #152746 (remove#![allow(stable_features)]from most tests)VaListstdlib docs #152675 (ImproveVaListstdlib docs)sysinfoversion to0.38.2#152748 (Updatesysinfoversion to0.38.2)r? @ghost
Create a similar rollup