Skip to content

Rollup of 6 pull requests#152755

Merged
rust-bors[bot] merged 17 commits intorust-lang:mainfrom
jdonszelmann:rollup-hcFNB2j
Feb 17, 2026
Merged

Rollup of 6 pull requests#152755
rust-bors[bot] merged 17 commits intorust-lang:mainfrom
jdonszelmann:rollup-hcFNB2j

Conversation

@jdonszelmann
Copy link
Contributor

Successful merges:

r? @ghost

Create a similar rollup

ShoyuVanilla and others added 17 commits December 12, 2025 18:26
Unlike other systems, Windows requires runtime libraries to be present
in `PATH` or right next to the binary.

So, we copy the library next to the binary as the easier solution.
This struct was only wrapping `TyCtxt` in order to implement traits that
were removed by RUST-152636.

This commit also slightly simplifies the signature of `execute_job_incr`, by
having it call `tcx.dep_graph.data()` internally.
The need for a `HasDepContext` impl on tuples can be avoided by passing the
query vtable as part of an argument tuple instead.
Install LLVM DLL in the right place on Windows

Continuation of rust-lang#151795 towards rust-lang#151774.

Unlike other systems, Windows requires runtime libraries to be present in `PATH` or right next to the binary.
So, we copy the library next to the binary as the easier solution.

Tested building `rust-openssl` in debug and release modes, but the difference is within noise margin.
…lcnr

`-Znext-solver` Remove the forced ambiguity hack from search graph

As discussed in rust-lang/trait-system-refactor-initiative#257

r? lcnr
Remove `QueryCtxt` and trait `HasDepContext`

- Follow-up to rust-lang#152636.
- Potentially waiting on rust-lang#152703 to reduce conflicts.
---

With the `QueryContext` trait removed, wrapper struct `QueryCtxt` no longer serves a purpose and can be replaced with `TyCtxt` everywhere.

After that, the only obstacle to removing trait `HasDepContext` is `DepGraph::with_task`, which uses the trait to allow passing both a `TyCtxt` and a query vtable through the context argument. But we can achieve the same result by passing the vtable through the other argument instead, in a tuple alongside the query key.

r? nnethercote
…enkov

remove `#![allow(stable_features)]` from most tests

The only remaining usages are tests that specifically deal with feature gates.
This also deletes the very weird `#![feature(issue_5723_bootstrap)]`, a 13 year old "temporary fix" (rust-lang#5723).
Improve `VaList` stdlib docs

tracking issue: rust-lang#44930

Some improvements to the `VaList` documentation, at least adding an example. We should link to the reference for c-variadic functions once stable. I've tried to call out explicitly that the type is meant for sending over the FFI boundary.

r? workingjubilee
cc @tgross35
…uillaumeGomez

Update `sysinfo` version to `0.38.2`

r? ghost
@rust-bors rust-bors bot added the rollup A PR which is a rollup label Feb 17, 2026
@rustbot rustbot added A-CI Area: Our Github Actions CI A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Feb 17, 2026
@jdonszelmann
Copy link
Contributor Author

@bors r+ rollup=never p=5

@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 17, 2026

📌 Commit 8d26ccc has been approved by jdonszelmann

It is now in the queue for this repository.

@rust-bors rust-bors bot added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Feb 17, 2026
@rust-bors rust-bors bot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 17, 2026
@rust-bors

This comment has been minimized.

@rust-bors rust-bors bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 17, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 17, 2026

☀️ Test successful - CI
Approved by: jdonszelmann
Duration: 4h 8m 46s
Pushing dfbfbf7 to main...

@rust-bors rust-bors bot merged commit dfbfbf7 into rust-lang:main Feb 17, 2026
12 checks passed
@rustbot rustbot added this to the 1.95.0 milestone Feb 17, 2026
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#149904 -Znext-solver Remove the forced ambiguity hack from searc… 7305293ba2a333a921183c56502b53037e6b2ffc (link)
#152609 Install LLVM DLL in the right place on Windows aaab9506c9435c1d593c0cd873fa48a90b92457d (link)
#152675 Improve VaList stdlib docs 8ebbe5724dd949e9a93ecba2521bb35ea3f62861 (link)
#152704 Remove QueryCtxt and trait HasDepContext e362fad54a1cbd6595d40c93a850dd768e0326e8 (link)
#152746 remove #![allow(stable_features)] from most tests 82b4432ae486b17f58fc153d79b89044b2fdbab4 (link)
#152748 Update sysinfo version to 0.38.2 8d93c86c380fdd8f08598d28f3b8b1cc1eac452f (link)

previous master: 3f6250a7bb

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 3f6250a (parent) -> dfbfbf7 (this PR)

Test differences

Show 6 test diffs

Stage 1

  • [ui] tests/ui/traits/next-solver/global-where-bound-normalization.rs: [missing] -> pass (J1)

Stage 2

  • [ui] tests/ui/traits/next-solver/global-where-bound-normalization.rs: [missing] -> pass (J0)

Additionally, 4 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard dfbfbf785f46d10103e80735a9ccb4765bd6dfe2 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-apple-various: 1h 38m -> 2h 11m (+33.4%)
  2. pr-check-1: 28m 15s -> 33m 33s (+18.7%)
  3. dist-aarch64-apple: 1h 57m -> 2h 13m (+13.4%)
  4. x86_64-gnu-miri: 1h 14m -> 1h 22m (+12.0%)
  5. dist-aarch64-msvc: 1h 37m -> 1h 48m (+11.3%)
  6. pr-check-2: 38m 41s -> 43m 2s (+11.3%)
  7. x86_64-msvc-ext1: 2h 21m -> 2h 6m (-10.6%)
  8. x86_64-gnu-stable: 2h 15m -> 2h 29m (+10.0%)
  9. dist-aarch64-llvm-mingw: 1h 48m -> 1h 38m (-9.6%)
  10. dist-ohos-armv7: 1h 7m -> 1h 13m (+9.3%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (dfbfbf7): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -2.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-2.5% [-2.5%, -2.5%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -2.5% [-2.5%, -2.5%] 1

Cycles

Results (secondary -1.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
3.4% [3.4%, 3.4%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-3.8% [-4.8%, -2.8%] 2
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 480.825s -> 482.346s (0.32%)
Artifact size: 395.77 MiB -> 397.84 MiB (0.52%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-CI Area: Our Github Actions CI A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants