Rollup of 4 pull requests by matthiaskrgr · Pull Request #153642 · rust-lang/rust

matthiaskrgr · 2026-03-10T06:22:00Z

Successful merges:

In Option::get_or_insert_with(), forget the None instead of dropping it. #148562 (In Option::get_or_insert_with(), forget the None instead of dropping it.)
tests/ui/cfg: add annotations for reference rules #153325 (tests/ui/cfg: add annotations for reference rules)
Remove TyCtxt::node_span_lint method #153621 (Remove TyCtxt::node_span_lint method)
rustdoc-json: Improve docs for ItemEnum::item_kind #153627 (rustdoc-json: Improve docs for ItemEnum::item_kind)

…ing it. This allows eliminating the `T: [const] Destruct` bounds and avoids generating an implicit `drop_in_place::<Option<T>>()` that will never do anything. Ideally, the compiler would prove that that drop is not necessary itself, but it currently doesn't, even with `const_precise_live_drops` enabled.

Fixes rust-lang#153279 (comment)

In `Option::get_or_insert_with()`, forget the `None` instead of dropping it. Per rust-lang#148486 (comment) In `Option::get_or_insert_with()`, after replacing the `None` with `Some`, forget the `None` instead of dropping it. This allows eliminating the `T: [const] Destruct` bounds, making the functions more flexible in (unstable) const contexts, and avoids generating an implicit `drop_in_place::<Option<T>>()` that will never do anything (and which might even persist after optimization).

…nditional-compilation, r=ehuss tests/ui/cfg: add annotations for reference rules

@JonathanBrouwer

…athanBrouwer Remove `TyCtxt::node_span_lint` method Part of rust-lang#153099. One less obstacle before we can remove `lint_level` function. :) r? @JonathanBrouwer

@GuillaumeGomez

…laumeGomez rustdoc-json: Improve docs for `ItemEnum::item_kind` Fixes rust-lang#153279 (comment) r? @GuillaumeGomez CC @LukeMathWalker

matthiaskrgr · 2026-03-10T06:22:35Z

@bors r+ rollup=never p=5

rust-bors · 2026-03-10T06:22:42Z

📌 Commit b01e56d has been approved by matthiaskrgr

It is now in the queue for this repository.

Rollup of 4 pull requests Successful merges: - #148562 (In `Option::get_or_insert_with()`, forget the `None` instead of dropping it.) - #153325 (tests/ui/cfg: add annotations for reference rules) - #153621 (Remove `TyCtxt::node_span_lint` method) - #153627 (rustdoc-json: Improve docs for `ItemEnum::item_kind`)

rust-bors · 2026-03-10T09:31:57Z

💔 Test for 2254b92 failed: CI. Failed job:

auto - x86_64-gnu-miri (web logs, enhanced plaintext logs)

rust-log-analyzer · 2026-03-10T09:42:37Z

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

/dev/sda15      105M  6.2M   99M   6% /boot/efi
tmpfs           1.6G   12K  1.6G   1% /run/user/1001
================================================================================

Sufficient disk space available (95007120KB >= 52428800KB). Skipping cleanup.
##[group]Run src/ci/scripts/setup-environment.sh
src/ci/scripts/setup-environment.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
---
##[endgroup]
Image input checksum 72ecab2d23f2d77608df76481a5ada15b19d498a7dc3d48372c9a7a712b5b5ebbf396a23a20676c985663ba6d58ad0821d6c2d4213f3296bb226507df1b7fa67
##[group]Building docker image for x86_64-gnu-miri
Docker version 28.0.4, build b8034c0
Error response from daemon: Get "https://ghcr.io/v2/": Get "https://ghcr.io/token?account=rust-lang&client_id=docker&offline_token=true&service=ghcr.io": net/http: request canceled (Client.Timeout exceeded while awaiting headers) (Client.Timeout exceeded while awaiting headers)
##[error]Process completed with exit code 1.
##[group]Run echo "disk usage:"
echo "disk usage:"
df -h
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}

Zalathar · 2026-03-10T09:51:04Z

Looks like we're seeing a streak of network failures.

@bors treeclosed=1000

rust-bors · 2026-03-10T09:51:08Z

Tree closed for PRs with priority less than 1000.

JonathanBrouwer · 2026-03-10T09:53:49Z

@bors retry

JonathanBrouwer · 2026-03-10T09:56:29Z

@bors p=1000

Rollup of 4 pull requests Successful merges: - #148562 (In `Option::get_or_insert_with()`, forget the `None` instead of dropping it.) - #153325 (tests/ui/cfg: add annotations for reference rules) - #153621 (Remove `TyCtxt::node_span_lint` method) - #153627 (rustdoc-json: Improve docs for `ItemEnum::item_kind`)

rust-bors · 2026-03-10T10:03:55Z

💔 Test for 5c216d1 failed: CI. Failed job:

auto - x86_64-gnu (web logs, enhanced plaintext logs)

JonathanBrouwer · 2026-03-10T10:31:45Z

@bors retry

rust-bors · 2026-03-10T10:31:57Z

⌛ Testing commit b01e56d with merge 0c68443...

Workflow: https://github.com/rust-lang/rust/actions/runs/22898245678

Rollup of 4 pull requests Successful merges: - #148562 (In `Option::get_or_insert_with()`, forget the `None` instead of dropping it.) - #153325 (tests/ui/cfg: add annotations for reference rules) - #153621 (Remove `TyCtxt::node_span_lint` method) - #153627 (rustdoc-json: Improve docs for `ItemEnum::item_kind`)

rust-log-analyzer · 2026-03-10T11:46:49Z

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

/dev/sda15      105M  6.2M   99M   6% /boot/efi
tmpfs           1.6G   12K  1.6G   1% /run/user/1001
================================================================================

Sufficient disk space available (95909384KB >= 52428800KB). Skipping cleanup.
##[group]Run src/ci/scripts/setup-environment.sh
src/ci/scripts/setup-environment.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}

kpreid and others added 11 commits November 23, 2025 15:00

tests/ui/cfg: add annotations for reference rules

226b4dd

Remove usage of TyCtxt::node_span_lint in librustdoc

4c48a5b

rustdoc-json: Improve docs for ItemEnum::item_kind

ca9bd0d

Fixes rust-lang#153279 (comment)

Remove usage of TyCtxt::node_span_lint in clippy

e54a3d3

Remove TyCtxt::node_span_lint method

562e981

Remove TyCtxt::node_span_lint mention in docs

4d7624e

Rollup merge of rust-lang#153325 - DanielEScherzer:test-references-co…

4e0adfe

…nditional-compilation, r=ehuss tests/ui/cfg: add annotations for reference rules

Rollup merge of rust-lang#153621 - GuillaumeGomez:migrate-diag, r=Jon…

531dafd

…athanBrouwer Remove `TyCtxt::node_span_lint` method Part of rust-lang#153099. One less obstacle before we can remove `lint_level` function. :) r? @JonathanBrouwer

Rollup merge of rust-lang#153627 - aDotInTheVoid:rustdocsdocs, r=Guil…

b01e56d

…laumeGomez rustdoc-json: Improve docs for `ItemEnum::item_kind` Fixes rust-lang#153279 (comment) r? @GuillaumeGomez CC @LukeMathWalker

rust-bors bot added the rollup A PR which is a rollup label Mar 10, 2026

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 10, 2026

This comment has been minimized.

Sign in to view

rust-bors bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 10, 2026

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 10, 2026

This comment has been minimized.

Sign in to view

rust-bors bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 10, 2026

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 10, 2026

rust-bors bot mentioned this pull request Mar 10, 2026

Implement coercions between &pin (mut|const) T and &(mut) T when T: Unpin #149130

Open

This was referenced Mar 10, 2026

fix: don't suggest replacing env!("CARGO_BIN_NAME") with itself #152302

Open

Rollup of 4 pull requests #153654

Open

Uh oh!

Conversation

matthiaskrgr commented Mar 10, 2026

Uh oh!

matthiaskrgr commented Mar 10, 2026

Uh oh!

rust-bors bot commented Mar 10, 2026

Uh oh!

This comment has been minimized.

rust-bors bot commented Mar 10, 2026

Uh oh!

rust-log-analyzer commented Mar 10, 2026

Uh oh!

Zalathar commented Mar 10, 2026

Uh oh!

rust-bors bot commented Mar 10, 2026

Uh oh!

JonathanBrouwer commented Mar 10, 2026

Uh oh!

JonathanBrouwer commented Mar 10, 2026

Uh oh!

This comment has been minimized.

rust-bors bot commented Mar 10, 2026

Uh oh!

JonathanBrouwer commented Mar 10, 2026

Uh oh!

rust-bors bot commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-log-analyzer commented Mar 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

rust-bors bot commented Mar 10, 2026 •

edited

Loading