Remove unused SelectionCandidate::PointerLikeCandidate#153798
Open
zachs18 wants to merge 1 commit intorust-lang:mainfrom
Open
Remove unused SelectionCandidate::PointerLikeCandidate#153798zachs18 wants to merge 1 commit intorust-lang:mainfrom
SelectionCandidate::PointerLikeCandidate#153798zachs18 wants to merge 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
r? @JohnTitor rustbot has assigned @JohnTitor. Use Why was this reviewer chosen?The reviewer was selected based on:
|
JohnTitor
approved these changes
Mar 13, 2026
Member
There was a problem hiding this comment.
Thanks! I'm pretty sure it got left behind.
@bors r+ rollup
Contributor
rust-bors
bot
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 13, 2026
…e, r=JohnTitor Remove unused `SelectionCandidate::PointerLikeCandidate` The `PointerLike` trait was removed in rust-lang#143308, as part of `dyn*` being removed. `!null` pattern types were added in rust-lang#142339 , which added `SelectionCandidate::PointerLikeCandidate`, IIUC to allow pattern types to implement `PointerLike`, but `PointerLike` was removed after that PR was first written, so (I assume) that functionality was mostly removed on a rebase, but this part didn't get removed. (see an earlier version of that PR that mentioned `LangItem::PointerLike`: rust-lang@50cab82 before it got rebased over the rollup containing 143308: rust-lang#142339 (comment) ) cc @oli-obk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
PointerLiketrait was removed in #143308, as part ofdyn*being removed.!nullpattern types were added in #142339 , which addedSelectionCandidate::PointerLikeCandidate, IIUC to allow pattern types to implementPointerLike, butPointerLikewas removed after that PR was first written, so (I assume) that functionality was mostly removed on a rebase, but this part didn't get removed. (see an earlier version of that PR that mentionedLangItem::PointerLike: 50cab82 before it got rebased over the rollup containing 143308: #142339 (comment) )cc @oli-obk