refactor: move doc(rust_logo) check to parser#153980
Open
mehdiakiki wants to merge 1 commit intorust-lang:mainfrom
Open
refactor: move doc(rust_logo) check to parser#153980mehdiakiki wants to merge 1 commit intorust-lang:mainfrom
mehdiakiki wants to merge 1 commit intorust-lang:mainfrom
Conversation
Collaborator
|
Some changes occurred in compiler/rustc_passes/src/check_attr.rs cc @jdonszelmann, @JonathanBrouwer Some changes occurred in compiler/rustc_attr_parsing |
rustbot
added
S-waiting-on-review
Collaborator
|
r? @JohnTitor rustbot has assigned @JohnTitor. Use Why was this reviewer chosen?The reviewer was selected based on:
|
| Some(sym::fake_variadic) => no_args_and_not_crate_level!(fake_variadic), | ||
| Some(sym::search_unbox) => no_args_and_not_crate_level!(search_unbox), | ||
| Some(sym::rust_logo) => no_args_and_crate_level!(rust_logo), | ||
| Some(sym::rust_logo) => { |
Contributor
There was a problem hiding this comment.
Would be cool if we could somehow keep using these macros, otherwise you gotta write it out every time
Contributor
Author
There was a problem hiding this comment.
Sure, will do later today!
Contributor
|
r? me |
Contributor
|
@rustbot author |
rustbot
added
S-waiting-on-author
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reducing
check_attr.rssize by moving the#[doc(rust_logo)]feature gate intoDocParser.