Skip to content

refactor(attribute parser): move check_custom_mir to attribute parser#154126

Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
JayanAXHF:refactor/custom_mir_parser
Mar 20, 2026
Merged

refactor(attribute parser): move check_custom_mir to attribute parser#154126
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
JayanAXHF:refactor/custom_mir_parser

Conversation

@JayanAXHF
Copy link
Member

@JayanAXHF JayanAXHF commented Mar 20, 2026

@rustbot
Copy link
Collaborator

rustbot commented Mar 20, 2026

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann, @JonathanBrouwer

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann, @JonathanBrouwer

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 20, 2026
@rustbot
Copy link
Collaborator

rustbot commented Mar 20, 2026

JonathanBrouwer is currently at their maximum review capacity.
They may take a while to respond.

@JayanAXHF JayanAXHF added the C-cleanup Category: PRs that clean code up or issues documenting cleanup. label Mar 20, 2026
@JayanAXHF JayanAXHF added the A-frontend Area: Compiler frontend (errors, parsing and HIR) label Mar 20, 2026
Copy link
Contributor

@JonathanBrouwer JonathanBrouwer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JayanAXHF JayanAXHF force-pushed the refactor/custom_mir_parser branch from d99b4b9 to 5aeb2a6 Compare March 20, 2026 11:59
@JayanAXHF
Copy link
Member Author

@bors r=JonathanBrouwer

@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 20, 2026

@JayanAXHF: 🔑 Insufficient privileges: not in review users

@JayanAXHF
Copy link
Member Author

Oh sorry @JonathanBrouwer i forgot i was only in the triage team

@JonathanBrouwer
Copy link
Contributor

@bors r+ rollup

@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 20, 2026

📌 Commit 5aeb2a6 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 20, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Mar 20, 2026
…er, r=JonathanBrouwer

refactor(attribute parser): move check_custom_mir to attribute parser

Part of rust-lang#153101

r? @JonathanBrouwer
rust-bors bot pushed a commit that referenced this pull request Mar 20, 2026
…uwer

Rollup of 5 pull requests

Successful merges:

 - #154103 (coretests: Expand ieee754 parsing and printing tests to f16)
 - #152669 (rustc_public: add `vtable_entries()` to `TraitRef`)
 - #153776 (Remove redundant `is_dyn_thread_safe` checks)
 - #154121 (Fix typos and markdown errors)
 - #154126 (refactor(attribute parser): move check_custom_mir to attribute parser)
@rust-bors rust-bors bot merged commit e106b58 into rust-lang:main Mar 20, 2026
11 checks passed
@rustbot rustbot added this to the 1.96.0 milestone Mar 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) A-frontend Area: Compiler frontend (errors, parsing and HIR) C-cleanup Category: PRs that clean code up or issues documenting cleanup. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants