Rollup of 5 pull requests by JonathanBrouwer · Pull Request #154137 · rust-lang/rust

JonathanBrouwer · 2026-03-20T12:24:28Z

Successful merges:

coretests: Expand ieee754 parsing and printing tests to f16 #154103 (coretests: Expand ieee754 parsing and printing tests to f16)
rustc_public: add vtable_entries() to TraitRef #152669 (rustc_public: add vtable_entries() to TraitRef)
Remove redundant is_dyn_thread_safe checks #153776 (Remove redundant is_dyn_thread_safe checks)
Fix typos and markdown errors #154121 (Fix typos and markdown errors)
refactor(attribute parser): move check_custom_mir to attribute parser #154126 (refactor(attribute parser): move check_custom_mir to attribute parser)

This is just a single file, so move it under `num` which already has some float-related tests. This also closer mirrors source in `core`.

Use `float_test!` to cover all types, with a note about f128 missing the traits.

coretests: Expand ieee754 parsing and printing tests to f16 Use `float_test!` to cover all types, with a note about f128 missing the traits. Also includes some minor reorganization.

rustc_public: add `vtable_entries()` to `TraitRef` Resolves: rust-lang/project-stable-mir#103

…d-safe, r=JonathanBrouwer Remove redundant `is_dyn_thread_safe` checks Refactor uses of `FromDyn` to reduce number of redundant `is_dyn_thread_safe` checks by replacing `FromDyn::from` with `check_dyn_thread_safe` in tandem with existing `FromDyn::derive` so that the users would avoid redundancy in the future. PR is split up into multiple commits for an easier review.

…lmann Fix typos and markdown errors This PR fixes some typos and markdown errors I found while writing rust-lang#153697. I've split it out to reduce the size of that PR.

@JonathanBrouwer

…er, r=JonathanBrouwer refactor(attribute parser): move check_custom_mir to attribute parser Part of rust-lang#153101 r? @JonathanBrouwer

JonathanBrouwer · 2026-03-20T12:24:37Z

@bors r+ rollup=never p=5

JonathanBrouwer · 2026-03-20T12:24:42Z

Trying commonly failed jobs
@bors try jobs=test-various,x86_64-gnu-aux,x86_64-gnu-llvm-21-3,x86_64-msvc-1,aarch64-apple,x86_64-mingw-1

rust-bors · 2026-03-20T12:24:44Z

📌 Commit e106b58 has been approved by JonathanBrouwer

It is now in the queue for this repository.

Rollup of 5 pull requests try-job: test-various try-job: x86_64-gnu-aux try-job: x86_64-gnu-llvm-21-3 try-job: x86_64-msvc-1 try-job: aarch64-apple try-job: x86_64-mingw-1

rust-bors · 2026-03-20T15:09:54Z

💔 Test for f8368e8 failed: CI

rust-bors · 2026-03-20T17:29:52Z

☀️ Test successful - CI
Approved by: JonathanBrouwer
Duration: 3h 10m 49s
Pushing bfc05d6 to main...

github-actions · 2026-03-20T17:32:53Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 461e973 (parent) -> bfc05d6 (this PR)

Test differences

Show 1696 test diffs

Stage 1

floats::atanh::test_f64: pass -> [missing] (J1)
floats::clamp_min_is_nan::test_f64: pass -> [missing] (J1)
floats::classify::test_f128: pass -> [missing] (J1)
floats::from::const_::test_f64: pass -> [missing] (J1)
floats::from::test_f128: pass -> [missing] (J1)
floats::from_u16_i16::test_f64: pass -> [missing] (J1)
floats::is_finite::const_::test_f64: pass -> [missing] (J1)
floats::is_finite::test_f128: pass -> [missing] (J1)
floats::is_nan::test_f16: pass -> [missing] (J1)
floats::is_normal::const_::test_f32: pass -> [missing] (J1)
floats::max::const_::test_f64: pass -> [missing] (J1)
floats::max_exact_integer_constant::const_::test_f64: pass -> [missing] (J1)
floats::neg_infinity::const_::test_f32: pass -> [missing] (J1)
floats::neg_infinity::test_f64: pass -> [missing] (J1)
floats::neg_zero::test_f16: pass -> [missing] (J1)
floats::num::test_f64: pass -> [missing] (J1)
floats::one::const_::test_f128: pass -> [missing] (J1)
floats::round::const_::test_f128: pass -> [missing] (J1)
floats::to_algebraic::test_f128: pass -> [missing] (J1)
floats::to_degrees::test_f128: pass -> [missing] (J1)
floats::trunc::const_::test_f64: pass -> [missing] (J1)
num::float_ieee754_flt2dec_dec2flt::qnan_from_str::test_f64: [missing] -> pass (J1)
num::floats::ceil::const_::test_f16: [missing] -> pass (J1)
num::floats::classify::const_::test_f128: [missing] -> pass (J1)
num::floats::classify::const_::test_f32: [missing] -> pass (J1)
num::floats::classify::test_f32: [missing] -> pass (J1)
num::floats::copysign::test_f64: [missing] -> pass (J1)
num::floats::from::test_f128: [missing] -> pass (J1)
num::floats::is_finite::test_f32: [missing] -> pass (J1)
num::floats::is_sign_negative::const_::test_f16: [missing] -> pass (J1)
num::floats::ln_gamma::test_f16: [missing] -> pass (J1)
num::floats::max::const_::test_f32: [missing] -> pass (J1)
num::floats::max_exact_integer_constant::const_::test_f64: [missing] -> pass (J1)
num::floats::midpoint::const_::test_f16: [missing] -> pass (J1)
num::floats::midpoint::const_::test_f32: [missing] -> pass (J1)
num::floats::min::const_::test_f64: [missing] -> pass (J1)
num::floats::next_down::const_::test_f16: [missing] -> pass (J1)
num::floats::next_up::test_f16: [missing] -> pass (J1)
num::floats::num_rem::const_::test_f128: [missing] -> pass (J1)
num::floats::num_rem::const_::test_f32: [missing] -> pass (J1)
num::floats::real_consts::test_f64: [missing] -> pass (J1)
num::floats::sqrt_domain::test_f16: [missing] -> pass (J1)
num::floats::to_algebraic::test_f16: [missing] -> pass (J1)
num::floats::to_bits_conv::const_::test_f16: [missing] -> pass (J1)
num::floats::to_radians::const_::test_f64: [missing] -> pass (J1)
num::floats::total_cmp::const_::test_f64: [missing] -> pass (J1)

Stage 2

floats::floor::const_::test_f32: pass -> [missing] (J0)
floats::gamma::test_f64: pass -> [missing] (J0)
floats::is_nan::test_f32: pass -> [missing] (J0)
floats::is_sign_negative::const_::test_f64: pass -> [missing] (J0)
floats::ln::test_f32: pass -> [missing] (J0)
floats::log10::test_f64: pass -> [missing] (J0)
floats::log2::test_f32: pass -> [missing] (J0)
floats::max::const_::test_f32: pass -> [missing] (J0)
floats::midpoint::const_::test_f128: pass -> [missing] (J0)
floats::mul_add::const_::test_f16: pass -> [missing] (J0)
floats::powf::test_f32: pass -> [missing] (J0)
floats::round::const_::test_f64: pass -> [missing] (J0)
floats::to_algebraic::test_f64: pass -> [missing] (J0)
floats::trunc::const_::test_f32: pass -> [missing] (J0)
floats::trunc::test_f32: pass -> [missing] (J0)
num::floats::asinh::test_f32: [missing] -> pass (J0)
num::floats::asinh::test_f64: [missing] -> pass (J0)
num::floats::div_euclid::test_f32: [missing] -> pass (J0)
num::floats::exp2::test_f64: [missing] -> pass (J0)
num::floats::infinity::const_::test_f16: [missing] -> pass (J0)
num::floats::is_infinite::test_f32: [missing] -> pass (J0)
num::floats::is_sign_positive::test_f32: [missing] -> pass (J0)
num::floats::max::test_f32: [missing] -> pass (J0)
num::floats::midpoint::const_::test_f16: [missing] -> pass (J0)
num::floats::midpoint::const_::test_f32: [missing] -> pass (J0)
num::floats::min::const_::test_f128: [missing] -> pass (J0)
num::floats::num::test_f32: [missing] -> pass (J0)
num::floats::num_rem::const_::test_f128: [missing] -> pass (J0)
num::floats::num_rem::const_::test_f16: [missing] -> pass (J0)
num::floats::round_ties_even::const_::test_f16: [missing] -> pass (J0)
num::floats::signum::const_::test_f64: [missing] -> pass (J0)
num::floats::to_bits_conv::test_f32: [missing] -> pass (J0)
num::floats::to_degrees::const_::test_f128: [missing] -> pass (J0)
num::floats::total_cmp::const_::test_f32: [missing] -> pass (J0)
num::floats::zero::const_::test_f16: [missing] -> pass (J0)
floats::ln::test_f16: pass -> [missing] (J2)
floats::is_finite::test_f128: pass -> [missing] (J3)
floats::max::test_f16: pass -> [missing] (J3)
floats::max_exact_integer_constant::test_f16: pass -> [missing] (J3)
floats::min_exact_integer_constant::test_f128: pass -> [missing] (J3)
floats::next_up::test_f16: pass -> [missing] (J3)
floats::trunc::test_f16: pass -> [missing] (J3)
num::floats::abs::test_f16: [missing] -> pass (J3)
num::floats::classify::test_f16: [missing] -> pass (J3)
num::floats::floor::test_f16: [missing] -> pass (J3)
num::floats::min_exact_integer_constant::test_f128: [missing] -> pass (J3)
num::floats::min_exact_integer_constant::test_f16: [missing] -> pass (J3)
num::floats::one::test_f16: [missing] -> pass (J3)
num::floats::recip::test_f16: [missing] -> pass (J3)
floats::mul_add::test_f32: ignore -> [missing] (J4)
floats::floor::test_f128: pass -> [missing] (J5)
floats::maximum::test_f128: pass -> [missing] (J5)
floats::signum::test_f128: pass -> [missing] (J5)
num::floats::rem_euclid::test_f128: [missing] -> pass (J5)

(and 1590 additional test diffs)

Additionally, 6 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard bfc05d6b072585dfd0c792ec1b8728c08a3511fe --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-x86_64-apple: 1h 46m -> 2h 14m (+25.8%)
dist-aarch64-apple: 1h 40m -> 2h 6m (+25.2%)
x86_64-gnu: 2h 28m -> 2h 10m (-12.1%)
x86_64-gnu-llvm-21-2: 1h 28m -> 1h 39m (+11.7%)
x86_64-gnu-gcc: 1h 1m -> 1h 8m (+11.0%)
x86_64-gnu-llvm-22-2: 1h 30m -> 1h 39m (+10.1%)
x86_64-gnu-llvm-22-3: 1h 57m -> 1h 45m (-10.1%)
dist-powerpc64-linux-musl: 1h 31m -> 1h 40m (+9.5%)
dist-x86_64-solaris: 1h 39m -> 1h 30m (-9.0%)
x86_64-gnu-llvm-22-1: 1h 12m -> 1h 18m (+8.8%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2026-03-20T18:11:16Z

Finished benchmarking commit (bfc05d6): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (secondary 3.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.1%	[3.1%, 3.1%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 488.876s -> 485.797s (-0.63%)
Artifact size: 396.98 MiB -> 396.97 MiB (-0.00%)

makai410 and others added 16 commits March 16, 2026 23:25

rustc_public: add vtable_entries() to TraitRef

042875b

rustc_public: add vtable_entry

96893dc

Move FromDyn closer to is_dyn_thread_safe

15f42e2

Remove FromDyn::from and add check_dyn_thread_safe

3973d9f

coretests: Move the float module under num

f9c0284

This is just a single file, so move it under `num` which already has some float-related tests. This also closer mirrors source in `core`.

coretests: Give ieee754.rs a more accurate name

4211234

coretests: Expand ieee754 parsing and printing tests to f16

16f8985

Use `float_test!` to cover all types, with a note about f128 missing the traits.

Update typos.toml allow list

22e1148

Fix typos and outdated comments

55d9f7c

Fix markdown warnings in ui/README.md

65335b6

refactor(attribute parser): move check_custom_mir to attribute parser

5aeb2a6

Rollup merge of rust-lang#154103 - tgross35:float-test-mod, r=folkertdev

c82d8db

coretests: Expand ieee754 parsing and printing tests to f16 Use `float_test!` to cover all types, with a note about f128 missing the traits. Also includes some minor reorganization.

Rollup merge of rust-lang#152669 - makai410:rpub-vtable, r=celinval

65f1783

rustc_public: add `vtable_entries()` to `TraitRef` Resolves: rust-lang/project-stable-mir#103

Rollup merge of rust-lang#154121 - teor2345:typos-md-03-20, r=jdonsze…

c6cfaca

…lmann Fix typos and markdown errors This PR fixes some typos and markdown errors I found while writing rust-lang#153697. I've split it out to reduce the size of that PR.

Rollup merge of rust-lang#154126 - JayanAXHF:refactor/custom_mir_pars…

e106b58

…er, r=JonathanBrouwer refactor(attribute parser): move check_custom_mir to attribute parser Part of rust-lang#153101 r? @JonathanBrouwer

rust-bors bot added the rollup A PR which is a rollup label Mar 20, 2026

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 20, 2026

This comment has been minimized.

Sign in to view

JayanAXHF mentioned this pull request Mar 20, 2026

Rollup of 5 pull requests #154136

Closed

This comment has been minimized.

Sign in to view

rust-bors bot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Mar 20, 2026

rust-bors bot added the merged-by-bors This PR was explicitly merged by bors. label Mar 20, 2026

rust-bors bot removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 20, 2026

rust-bors bot merged commit bfc05d6 into rust-lang:main Mar 20, 2026
12 of 13 checks passed

rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Mar 20, 2026

rustbot added this to the 1.96.0 milestone Mar 20, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 5 pull requests#154137

Rollup of 5 pull requests#154137
rust-bors[bot] merged 16 commits intorust-lang:mainfrom
JonathanBrouwer:rollup-hTMxxjl

JonathanBrouwer commented Mar 20, 2026

Uh oh!

JonathanBrouwer commented Mar 20, 2026

Uh oh!

JonathanBrouwer commented Mar 20, 2026

Uh oh!

rust-bors bot commented Mar 20, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-bors bot commented Mar 20, 2026

Uh oh!

rust-bors bot commented Mar 20, 2026

Uh oh!

Uh oh!

github-actions bot commented Mar 20, 2026

Stage 1

Stage 2

Uh oh!

rust-timer commented Mar 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Uh oh!

Conversation

JonathanBrouwer commented Mar 20, 2026

Uh oh!

JonathanBrouwer commented Mar 20, 2026

Uh oh!

JonathanBrouwer commented Mar 20, 2026

Uh oh!

rust-bors bot commented Mar 20, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-bors bot commented Mar 20, 2026

Uh oh!

rust-bors bot commented Mar 20, 2026

Uh oh!

Uh oh!

github-actions bot commented Mar 20, 2026

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Mar 20, 2026

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants