Skip to content

core/num: Fix feature name for unstable integer_extend_truncate functions#155004

Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
okaneco:fix_truncate_extend_label
Apr 9, 2026
Merged

core/num: Fix feature name for unstable integer_extend_truncate functions#155004
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
okaneco:fix_truncate_extend_label

Conversation

@okaneco
Copy link
Copy Markdown
Contributor

@okaneco okaneco commented Apr 8, 2026

Tracking issue: #154330
Feature gate: #![feature(integer_extend_truncate)]


The feature name for the const unstable attribute was accidentally transposed when const traits were added in 68c8339.

        #[unstable(feature = "integer_extend_truncate", issue = "154330")]
+       #[rustc_const_unstable(feature = "integer_truncate_extend", issue = "154330")]

The feature name for the const unstable attribute was
accidentally transposed when const traits were added.
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 8, 2026
@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Apr 8, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 8, 2026

r? @scottmcm

rustbot has assigned @scottmcm.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @scottmcm, libs
  • @scottmcm, libs expanded to 8 candidates
  • Random selection from Mark-Simulacrum, scottmcm

@jhpratt
Copy link
Copy Markdown
Member

jhpratt commented Apr 8, 2026

Nice catch

@bors r+ rollup

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Apr 8, 2026

📌 Commit c1ac769 has been approved by jhpratt

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 8, 2026
rust-bors bot pushed a commit that referenced this pull request Apr 9, 2026
Rollup of 10 pull requests

Successful merges:

 - #150316 (Do not use non-wf input expectations from fudge when checking function calls)
 - #152859 (`-Znext-solver` use the trait object's own bounds instead of goal when considering builtin object bounds)
 - #154856 (Fix linking two dylibs together when both depend on profiler_builtins)
 - #153888 (Avoid stack overflow in FindExprBySpan)
 - #154991 (Fix ICE in next-solver TransmuteFrom candidate)
 - #154995 (min/max_by tests: also check result)
 - #155004 (core/num: Fix feature name for unstable `integer_extend_truncate` functions)
 - #155007 (renaming method is_impl_trait to is_opaque)
 - #155009 (meta: Add checkboxes to unsresolved questions in issue templates)
 - #155017 (Update tracking issue number of future-incompatibility lint `unstable_syntax_pre_expansion`)
@rust-bors rust-bors bot merged commit 0cea5ee into rust-lang:main Apr 9, 2026
11 checks passed
@rustbot rustbot added this to the 1.96.0 milestone Apr 9, 2026
rust-timer added a commit that referenced this pull request Apr 9, 2026
Rollup merge of #155004 - okaneco:fix_truncate_extend_label, r=jhpratt

core/num: Fix feature name for unstable `integer_extend_truncate` functions

Tracking issue: #154330
Feature gate: `#![feature(integer_extend_truncate)]`

---

The feature name for the const unstable attribute was accidentally transposed when const traits were added in 68c8339.
```diff
        #[unstable(feature = "integer_extend_truncate", issue = "154330")]
+       #[rustc_const_unstable(feature = "integer_truncate_extend", issue = "154330")]
```
@okaneco okaneco deleted the fix_truncate_extend_label branch April 9, 2026 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants