Skip to content

Update tracking issue number of future-incompatibility lint unstable_syntax_pre_expansion#155017

Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
fmease:update-issue-number-unstable_syntax_pre_expansion
Apr 9, 2026
Merged

Update tracking issue number of future-incompatibility lint unstable_syntax_pre_expansion#155017
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
fmease:update-issue-number-unstable_syntax_pre_expansion

Conversation

@fmease
Copy link
Copy Markdown
Member

@fmease fmease commented Apr 8, 2026

Issue #65860 has never been a proper tracking issue, it has always been a normal issue that reported a pass→fail regression which was subsequently fixed and which elicited a discussion spanning 50 comments. Years later the formerly offending errors were reintroduced as warnings which link to said issue (see section Pre-History in issue #154045 for details).

A few weeks ago I closed this issue (#65860 (comment)) in favor of a new super focused & structured tracking issue, #154045. That means people now have to jump through hoops to arrive at the new tracking issue which is less than ideal (it's very likely that this user had to do so: #154045 (comment)), let's fix that.

Part of #154045.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 8, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 8, 2026

r? @dingxiangfei2009

rustbot has assigned @dingxiangfei2009.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 69 candidates
  • Random selection from 11 candidates

Copy link
Copy Markdown
Member

@Kivooeo Kivooeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with ci green

View changes since this review

@Kivooeo Kivooeo assigned Kivooeo and unassigned dingxiangfei2009 Apr 8, 2026
@fmease
Copy link
Copy Markdown
Member Author

fmease commented Apr 9, 2026

@bors r=Kivooeo rollup

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Apr 9, 2026

📌 Commit 2d33b30 has been approved by Kivooeo

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 9, 2026
rust-bors bot pushed a commit that referenced this pull request Apr 9, 2026
Rollup of 10 pull requests

Successful merges:

 - #150316 (Do not use non-wf input expectations from fudge when checking function calls)
 - #152859 (`-Znext-solver` use the trait object's own bounds instead of goal when considering builtin object bounds)
 - #154856 (Fix linking two dylibs together when both depend on profiler_builtins)
 - #153888 (Avoid stack overflow in FindExprBySpan)
 - #154991 (Fix ICE in next-solver TransmuteFrom candidate)
 - #154995 (min/max_by tests: also check result)
 - #155004 (core/num: Fix feature name for unstable `integer_extend_truncate` functions)
 - #155007 (renaming method is_impl_trait to is_opaque)
 - #155009 (meta: Add checkboxes to unsresolved questions in issue templates)
 - #155017 (Update tracking issue number of future-incompatibility lint `unstable_syntax_pre_expansion`)
rust-timer added a commit that referenced this pull request Apr 9, 2026
Rollup merge of #155017 - fmease:update-issue-number-unstable_syntax_pre_expansion, r=Kivooeo

Update tracking issue number of future-incompatibility lint `unstable_syntax_pre_expansion`

Issue #65860 has never been a proper tracking issue, it has always been a normal issue that reported a pass→fail regression which was subsequently fixed and which elicited a discussion spanning 50 comments. Years later the formerly offending errors were reintroduced as warnings which link to said issue (see section *Pre-History* in issue #154045 for details).

A few weeks ago I closed this issue (#65860 (comment)) in favor of a new super focused & structured tracking issue, #154045. That means people now have to jump through hoops to arrive at the new tracking issue which is less than ideal (it's very likely that this user had to do so: #154045 (comment)), let's fix that.

Part of #154045.
@rust-bors rust-bors bot merged commit 1166f31 into rust-lang:main Apr 9, 2026
11 checks passed
@rustbot rustbot added this to the 1.96.0 milestone Apr 9, 2026
@fmease fmease deleted the update-issue-number-unstable_syntax_pre_expansion branch April 9, 2026 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants