Set the Fuchsia ABI to the documented minimum#155072
Open
ilovepi wants to merge 1 commit intorust-lang:mainfrom
Open
Set the Fuchsia ABI to the documented minimum#155072ilovepi wants to merge 1 commit intorust-lang:mainfrom
ilovepi wants to merge 1 commit intorust-lang:mainfrom
Conversation
Fuchsia only supports the RVA22 + vector as its minimum ABI for RISC-V. https://fuchsia.dev/fuchsia-src/contribute/governance/rfcs/0234_riscv_abi_rva22+vector
Collaborator
|
These commits modify compiler targets. |
rustbot
added
S-waiting-on-review
Collaborator
|
r? @mati865 rustbot has assigned @mati865. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Contributor
Author
|
I should likely mention that we do set the same options in clang: https://github.com/llvm/llvm-project/blob/fda567137ec611fdcce24729118b4f56bec6bb13/clang/lib/Driver/ToolChains/Arch/RISCV.cpp#L321 |
Member
|
(This itself seems fine, EDIT: the link is https://fuchsia.dev/fuchsia-src/contribute/governance/rfcs/0234_riscv_abi_rva22+v) |
jieyouxu
added
relnotes
jieyouxu
approved these changes
Apr 10, 2026
Contributor
rust-bors
bot
added
the
S-waiting-on-bors
rust-bors
bot
removed
the
S-waiting-on-review
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Apr 10, 2026
…lt, r=jieyouxu Set the Fuchsia ABI to the documented minimum Fuchsia only supports the RVA22 + vector as its minimum ABI for RISC-V. See: [fuchsia.dev/fuchsia-src/contribute/governance/rfcs/0234_riscv_abi_rva22+v](https://fuchsia.dev/fuchsia-src/contribute/governance/rfcs/0234_riscv_abi_rva22+v)[fuchsia.dev/fuchsia-src/contribute/governance/rfcs/0234_riscv_abi_rva22+v](https://fuchsia.dev/fuchsia-src/contribute/governance/rfcs/0234_riscv_abi_rva22+v)
rust-bors bot
pushed a commit
that referenced
this pull request
Apr 10, 2026
Rollup of 10 pull requests Successful merges: - #154973 (Break a single query cycle in the deadlock handler) - #155034 (Implement `GenericTypeVisitable` for some types) - #151377 (Fix linker error by resolving regions for main return type obligations) - #154677 (hwaddress: automatically add `-Ctarget-feature=+tagged-globals`) - #154774 (Add myself as co-maintainer for hexagon-unknown-linux-musl) - #155015 (Add tests for three fixed issues (an LLVM crash, an ICE and poor codegen)) - #155039 (minor follow up to removing soft mode `#[unstable]`) - #155043 (Fix if branch in op.rs) - #155071 (Deny `#[global_allocator]` + `#[thread_local]`) - #155072 (Set the Fuchsia ABI to the documented minimum)
Contributor
Author
oh, good catch! thanks for fixing the desciption. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fuchsia only supports the RVA22 + vector as its minimum ABI for RISC-V.
See: fuchsia.dev/fuchsia-src/contribute/governance/rfcs/0234_riscv_abi_rva22+vfuchsia.dev/fuchsia-src/contribute/governance/rfcs/0234_riscv_abi_rva22+v