resolve: Remove inaccessible_ctor_reexport resolver field#155353
Open
petrochenkov wants to merge 3 commits intorust-lang:mainfrom
Open
resolve: Remove inaccessible_ctor_reexport resolver field#155353petrochenkov wants to merge 3 commits intorust-lang:mainfrom
inaccessible_ctor_reexport resolver field#155353petrochenkov wants to merge 3 commits intorust-lang:mainfrom
Conversation
Use imports instead
Collect the necessary information during error reporting instead of doing it on a good path from the core name resolution infra
rustbot
added
S-waiting-on-review
Collaborator
|
r? @jackh726 rustbot has assigned @jackh726. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Contributor
Author
|
Let's try it |
Collaborator
|
Failed to set assignee to
|
Contributor
Author
|
Ah, not yet, rust-lang/team#2417 is probably not deployed yet. |
Member
|
r? me |
mu001999
reviewed
Apr 16, 2026
Member
|
LGTM! Just have a question about the interaction with inherent assoc types. So @bors r+ |
Contributor
rust-bors
bot
added
S-waiting-on-bors
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Apr 16, 2026
resolve: Remove `inaccessible_ctor_reexport` resolver field Collect the necessary information during error reporting instead of doing it on a good path from the core name resolution infra. Also cleanup the related diagnostic code for struct constructors in general, see the individual commits. This mitigates most of the harm brought by rust-lang#133477.
rust-bors bot
pushed a commit
that referenced
this pull request
Apr 16, 2026
Rollup of 18 pull requests Successful merges: - #154595 (Emit fatal on invalid const args with nested defs) - #154599 (report the `varargs_without_pattern` lint in deps) - #154699 (`core::unicode`: Replace `Cased` table with `Lt`) - #155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field) - #155357 (Add `--remap-path-scope` as unstable in rustdoc) - #150649 (clippy fix: non_canonical_clone_impl) - #154604 (abort in core) - #154616 (Add `--quiet` flag to x.py and bootstrap to suppress output) - #154970 (rustdoc: preserve `doc(cfg)` on locally re-exported type aliases) - #155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting) - #155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions) - #155266 (Adjust release notes for post-merge feedback) - #155326 (Disallow ZST allocations with `TypedArena`.) - #155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests) - #155340 (Handle nonnull pattern types in size skeleton) - #155347 (Add push_mut and new Layout methods to release notes) - #155356 (remove calls to AliasTyKind::def_id) - #155364 (Reduce diagnostic type visibilities.)
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Apr 16, 2026
resolve: Remove `inaccessible_ctor_reexport` resolver field Collect the necessary information during error reporting instead of doing it on a good path from the core name resolution infra. Also cleanup the related diagnostic code for struct constructors in general, see the individual commits. This mitigates most of the harm brought by rust-lang#133477.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Collect the necessary information during error reporting instead of doing it on a good path from the core name resolution infra.
Also cleanup the related diagnostic code for struct constructors in general, see the individual commits.
This mitigates most of the harm brought by #133477.