Rollup of 19 pull requests by Zalathar · Pull Request #155416 · rust-lang/rust

Zalathar · 2026-04-17T06:18:03Z

Successful merges:

Suggest to bind self.x to x when field x may be in format string #141633 (Suggest to bind self.x to x when field x may be in format string)
c-variadic: fix implementation on avr #152980 (c-variadic: fix implementation on avr)
Extend core::char's documentation of casing issues (and fix a rustdoc bug) #154491 (Extend core::char's documentation of casing issues (and fix a rustdoc bug))
Use mutable pointers for Unix path buffers #155318 (Use mutable pointers for Unix path buffers)
Bump bootstrap to 1.96 beta #155335 (Bump bootstrap to 1.96 beta)
Remove AttributeSafety from BUILTIN_ATTRIBUTES #155354 (Remove AttributeSafety from BUILTIN_ATTRIBUTES)
rustdoc: preserve doc(cfg) on locally re-exported type aliases #154970 (rustdoc: preserve doc(cfg) on locally re-exported type aliases)
changed the information provided by (mut x) to mut x (Fix 155030) #155095 (changed the information provided by (mut x) to mut x (Fix 155030))
Make convert_while_ascii unsafe #155305 (Make convert_while_ascii unsafe)
ImproperCTypes: Move erasing_region_normalisation into helper function #155358 (ImproperCTypes: Move erasing_region_normalisation into helper function)
tests/debuginfo/basic-stepping.rs: Remove FIXME related to ZSTs #155377 (tests/debuginfo/basic-stepping.rs: Remove FIXME related to ZSTs)
Rearrange rustc_ast_pretty #155383 (Rearrange rustc_ast_pretty)
triagebot: notify on diagnostic attribute changes #155384 (triagebot: notify on diagnostic attribute changes)
Use box_new diagnostic item for Box::new suggestions #155386 (Use box_new diagnostic item for Box::new suggestions)
Small refactor of QueryJob::latch method #155391 (Small refactor of QueryJob::latch method)
Tweak how the "copy path" rustdoc button works to allow some accessibility tool to work with rustdoc #155395 (Tweak how the "copy path" rustdoc button works to allow some accessibility tool to work with rustdoc)
as_ref_unchecked docs link fix #155396 (as_ref_unchecked docs link fix)
compiletest: Remove the //@ should-ice directive #155411 (compiletest: Remove the //@ should-ice directive)
fix: typo in std::fs::hard_link documentation #155413 (fix: typo in std::fs::hard_link documentation)

* Extend `core::char`'s documentation of casing issues * Fix typos * Fix typo Co-authored-by: GrigorenkoPV <GrigorenkoPV+github@yandex.ru> * Document maximum 3x character expansion This is guaranteed by Unicode. * Fix error in `str` casing method docs

Another interal change that shouldn't impact rustc users. To prepare for the upcoming split of visit_type, we reorganise the instances of `cx.tcx.try_normalize_erasing_regions(cx.typing_env(), ty).unwrap_or(ty)` into a helper function outside of the main structs.

We don't consider it a bug that users can't break on initialization of some non-zero sized types (see comment on `maximally-steppable` at the top of the file), so it does not make sense to consider it a bug that users can't break on initialization of some zero-sized types.

When a type alias is locally re-exported from a private module (an implicit inline), rustdoc drops its `cfg` attributes because it treats it like a standard un-inlined re-export. Since type aliases have no inner fields to carry the `cfg` badge (unlike structs or enums), the portability info is lost entirely. This patch explicitly preserves the target's `cfg` metadata when the generated item is a `TypeAliasItem`, ensuring the portability badge renders correctly without breaking standard cross-crate re-export behavior.

For no apparent reason it's in a different file to `Token` itself. This commit moves it.

`rustc_ast_pretty::pp` defines `Printer` and has a 346 line `impl Printer` block for it. `rustc_ast_pretty::pp::convenience` has another `impl Printer` block with 85 lines. `rustc_ast_pretty::helpers` has another `impl Printer` block with 45 lines. This commit merges the two small `impl Printer` blocks into the bigger one, because there is no good reason for them to be separate. Doing this eliminates the `rustc_ast_pretty::pp::convenience` and `rustc_ast_pretty::helpers` modules; no great loss given that they were small and had extremely generic names.

so that we can check whether a type implements the trait

…ility tool to work with rustdoc

This directive was only being used by one test, which can just as easily use the more general `//@ failure-status` directive instead. All of the removed exit-code checks were redundant with other exit-code checks that are still present.

@fmease

Suggest to bind `self.x` to `x` when field `x` may be in format string Fixes rust-lang#141350 I added the new test in the first commit, and committed the changes in the second one. r? @fmease cc @mejrs

@Patryk27

c-variadic: fix implementation on `avr` tracking issue: rust-lang#44930 cc target maintainer @Patryk27 I ran into multiple issues, and although with this PR and a little harness I can run the test with qemu on avr, the implementation is perhaps not ideal. The problem we found is that on `avr` the `c_int/c_uint` types are `i16/u16`, and this was not handled in the c-variadic checks. Luckily there is a field in the target configuration that contains the targets `c_int_width`. However, this field is not actually used in `core` at all, there the 16-bit targets are just hardcoded. https://github.com/rust-lang/rust/blob/1500f0f47f5fe8ddcd6528f6c6c031b210b4eac5/library/core/src/ffi/primitives.rs#L174-L185 Perhaps we should expose this like endianness and pointer width? --- Finally there are some changes to the test to make it compile with `no_std`.

@rustbot

…Simulacrum,GuillaumeGomez Extend `core::char`'s documentation of casing issues (and fix a rustdoc bug) @rustbot label A-unicode A-docs

Use mutable pointers for Unix path buffers This gets mutable pointers for Unix path buffers to ensure they have the right provenance.

…jieyouxu Bump bootstrap to 1.96 beta See https://forge.rust-lang.org/release/process.html#default-branch-bootstrap-update-tuesday I think this will wind up needing another PR in a week or so when we pick up assert_matches getting destabilized in beta? But that seems like it can be split into its own PR.

@jdonszelmann

…, r=mejrs Remove AttributeSafety from BUILTIN_ATTRIBUTES Encodes the expected attribute safety in the attribute parsers, rather than in `BUILTIN_ATTRIBUTES`, with the goal of removing `BUILTIN_ATTRIBUTES` soon. We can remove the old attribute safety logic already because unparsed attributes, just like the as of yet unparsed lint attributes, need to be safe. r? @jdonszelmann (or @mejrs if you feel like doing it, since you are in T-compiler now 🎉)

Zalathar · 2026-04-17T06:20:26Z

Rollup of everything.

This rollup incorporates all of Rollup of 13 pull requests #155407, which failed in a way that looks bogus, and is currently running a try job to investigate whether the failure is consistent.

@bors r+ rollup=never p=5

rust-bors · 2026-04-17T06:20:29Z

📌 Commit 9de2e2b has been approved by Zalathar

It is now in the queue for this repository.

rust-bors · 2026-04-17T11:12:05Z

☀️ Test successful - CI
Approved by: Zalathar
Duration: 3h 36m 11s
Pushing 27dbdb5 to main...

github-actions · 2026-04-17T11:15:10Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 1b8f2e4 (parent) -> 27dbdb5 (this PR)

Test differences

Show 528 test diffs

Stage 1

[rustdoc-html] tests/rustdoc-html/reexport/type-alias-reexport.rs: [missing] -> pass (J1)
[rustdoc-html] tests/rustdoc-html/unicode.rs: [missing] -> pass (J1)
[ui] tests/ui/borrowck/borrowck_for_loop_pattern_assignment.rs: [missing] -> pass (J1)

Stage 2

[rustdoc-html] tests/rustdoc-html/reexport/type-alias-reexport.rs: [missing] -> pass (J0)
[rustdoc-html] tests/rustdoc-html/unicode.rs: [missing] -> pass (J0)
[ui] tests/ui/borrowck/borrowck_for_loop_pattern_assignment.rs: [missing] -> pass (J2)

Additionally, 522 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 27dbdb57a2f90b5c90247e6ef14f2657a03473da --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

i686-msvc-2: 1h 41m -> 2h 22m (+39.6%)
x86_64-gnu-llvm-21-2: 1h 17m -> 1h 44m (+35.6%)
x86_64-gnu-llvm-21: 1h 1m -> 1h 19m (+29.6%)
dist-arm-linux-musl: 1h 18m -> 1h 41m (+29.0%)
dist-i686-msvc: 2h 26m -> 1h 51m (-23.7%)
i686-gnu-nopt-2: 2h 10m -> 1h 44m (-19.6%)
x86_64-gnu-aux: 2h 23m -> 1h 55m (-19.6%)
dist-x86_64-apple: 2h 31m -> 2h 5m (-17.3%)
x86_64-gnu-llvm-22-1: 1h 5m -> 1h 16m (+16.1%)
tidy: 2m 43s -> 3m 8s (+15.4%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2026-04-17T11:17:37Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#141633	Suggest to bind `self.x` to `x` when field `x` may be in fo…	`18a1047eae4d562ab157eb73e39e666e4e335400` (link)
#152980	c-variadic: fix implementation on `avr`	`44a47b8ff362e052d5fffd357848f32fb15d6155` (link)
#154491	Extend `core::char`'s documentation of casing issues (and f…	`a3ee818f17d4729da85ac1df275bcf6d0dc584ad` (link)
#154970	rustdoc: preserve `doc(cfg)` on locally re-exported type al…	`1c0ff795abb452b209a527ab53d0107c3c81bea6` (link)
#155095	changed the information provided by (mut x) to mut x (Fix 1…	`18eae9a52f6ffd4f11d3d4c48b7e87a1b87665e1` (link)
#155305	Make `convert_while_ascii` unsafe	`eb28f6ba8ec856c02998eb1c51ebb8acf63f8db8` (link)
#155318	Use mutable pointers for Unix path buffers	`6e7dacc995574b75bf930e96f093ca51fa8e8988` (link)
#155335	Bump bootstrap to 1.96 beta	`d9ff513e506199a3abbee48f5c6acfd6a82909a2` (link)
#155354	Remove AttributeSafety from BUILTIN_ATTRIBUTES	`67888153155d0fba8c9c41f2cbb12b5ea9874ce4` (link)
#155358	ImproperCTypes: Move erasing_region_normalisation into help…	`12df0ce58647a78b06fddbbaa33135eaff09a4fc` (link)
#155377	tests/debuginfo/basic-stepping.rs: Remove FIXME related to …	`1bbdcd639b1e2a8d67ef7bde94f77236bde4b235` (link)
#155383	Rearrange `rustc_ast_pretty`	`2d5bc9e4238964b92339a8b1f99a3e96f7fac023` (link)
#155384	triagebot: notify on diagnostic attribute changes	`0332c45160d9c7b66f77ef93a3c5a3d5cd27cceb` (link)
#155386	Use `box_new` diagnostic item for Box::new suggestions	`686fa52f6a84f4a832d681faae3bc65c72cb9f28` (link)
#155391	Small refactor of `QueryJob::latch` method	`3aee0d8157b47c23a8327a32a98cb650fbe77653` (link)
#155395	Tweak how the "copy path" rustdoc button works to allow som…	`7da676f81125c318055c7a82461e1cec928dc304` (link)
#155396	`as_ref_unchecked` docs link fix	`a506c8b0b76230ef9739aaa8752ea0db63110009` (link)
#155411	compiletest: Remove the `//@ should-ice` directive	`9050039d57dac150f90dd11c2d00af50cba4a2fb` (link)
#155413	fix: typo in `std::fs::hard_link` documentation	`01d2280a27aa091cc5624b83a7ee498372007bf5` (link)

previous master: 1b8f2e46e1

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2026-04-17T12:25:31Z

Finished benchmarking commit (27dbdb5): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.2%	[-0.2%, -0.2%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary -0.8%, secondary -0.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.5%	[1.5%, 1.5%]	1
Regressions ❌ (secondary)	5.0%	[3.5%, 6.5%]	2
Improvements ✅ (primary)	-1.6%	[-2.1%, -1.1%]	3
Improvements ✅ (secondary)	-3.3%	[-4.5%, -2.0%]	4
All ❌✅ (primary)	-0.8%	[-2.1%, 1.5%]	4

Cycles

Results (primary -8.5%, secondary -1.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.4%	[2.3%, 2.5%]	2
Improvements ✅ (primary)	-8.5%	[-13.4%, -2.9%]	11
Improvements ✅ (secondary)	-5.6%	[-7.4%, -3.8%]	2
All ❌✅ (primary)	-8.5%	[-13.4%, -2.9%]	11

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 504.175s -> 490.301s (-2.75%)
Artifact size: 394.15 MiB -> 394.23 MiB (0.02%)

xizheyin and others added 30 commits April 2, 2026 03:25

Avoid suggest format string field access for braced paths

c4f14ad

Make convert_while_ascii unsafe

99ed1b8

Apply replace-version-placeholder

f0827c6

add : new UI test

96fb37a

resolve : addressing incorrect recommendation methods

be3f77c

Remove AttributeSafety from BUILTIN_ATTRIBUTES

6236dde

rustdoc: percent-encode URL fragments

a9d7027

Move Token impl block.

0529b94

For no apparent reason it's in a different file to `Token` itself. This commit moves it.

c-variadic: handle c_int being i16 and c_double being f32 on avr

b8ba400

c-variadic: make VaArgSafe a lang item

a875e14

so that we can check whether a type implements the trait

Use box_new diagnostic item for Box::new suggestions

78a465a

Replace redundant unwrap with get_or_insert_with

d0f5b5c

triagebot: notify on diagnostic attribute changes

4645f03

as_ref_unchecked docs link fix

b2d2405

Tweak how the "copy path" rustdoc button works to allow some accessib…

6c4ec59

…ility tool to work with rustdoc

Use mutable pointers for Unix path buffers

7a47964

Bump stage0 to 1.96 beta

a64c420

Remove the //@ should-ice directive

975402e

This directive was only being used by one test, which can just as easily use the more general `//@ failure-status` directive instead. All of the removed exit-code checks were redundant with other exit-code checks that are still present.

Fix typo in documentation for CreateHardLink function

b05e29b

Rollup merge of rust-lang#141633 - xizheyin:issue-141350, r=nnethercote

1ff95e0

Suggest to bind `self.x` to `x` when field `x` may be in format string Fixes rust-lang#141350 I added the new test in the first commit, and committed the changes in the second one. r? @fmease cc @mejrs

Rollup merge of rust-lang#154491 - Jules-Bertholet:case-docs, r=Mark-…

3c61fba

…Simulacrum,GuillaumeGomez Extend `core::char`'s documentation of casing issues (and fix a rustdoc bug) @rustbot label A-unicode A-docs

Rollup merge of rust-lang#155318 - Zoxc:ub-issue-50, r=ChrisDenton

b7ea9df

Use mutable pointers for Unix path buffers This gets mutable pointers for Unix path buffers to ensure they have the right provenance.

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 17, 2026

This comment has been minimized.

Sign in to view

rust-bors bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 17, 2026

rust-bors bot merged commit 27dbdb5 into rust-lang:main Apr 17, 2026
12 checks passed

rustbot added this to the 1.97.0 milestone Apr 17, 2026

This was referenced Apr 17, 2026

[WIP] Introduce aarch64-unknown-linux-pauthtest target #154759

Draft

Make OnDuplicate::Error the default for attributes #155308

Open

lint ImproperCTypes: refactor linting architecture (part 3) #146275

Open

Zalathar deleted the rollup-D1EWnrR branch April 17, 2026 11:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 19 pull requests#155416

Rollup of 19 pull requests#155416
rust-bors[bot] merged 43 commits intorust-lang:mainfrom
Zalathar:rollup-D1EWnrR

Zalathar commented Apr 17, 2026

Uh oh!

Zalathar commented Apr 17, 2026

Uh oh!

rust-bors bot commented Apr 17, 2026

Uh oh!

This comment has been minimized.

rust-bors bot commented Apr 17, 2026

Uh oh!

Uh oh!

github-actions bot commented Apr 17, 2026

Stage 1

Stage 2

Uh oh!

rust-timer commented Apr 17, 2026

Uh oh!

rust-timer commented Apr 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Uh oh!

Conversation

Zalathar commented Apr 17, 2026

Uh oh!

Zalathar commented Apr 17, 2026

Uh oh!

rust-bors bot commented Apr 17, 2026

Uh oh!

This comment has been minimized.

rust-bors bot commented Apr 17, 2026

Uh oh!

Uh oh!

github-actions bot commented Apr 17, 2026

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Apr 17, 2026

Uh oh!

rust-timer commented Apr 17, 2026

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants