Rollup of 5 pull requests#155483
Open
JonathanBrouwer wants to merge 12 commits intorust-lang:mainfrom
Open
Conversation
…Lint`. The end goal being to completely remove `AttributeLint`.
…jdonszelmann Make `OnDuplicate::Error` the default for attributes This makes two changes, in separate commits for reviewability: - Changes all unstable attributes that are currently `OnDuplicate::Warn` to error. - Makes `OnDuplicate::Error` the default and removes the explicit `ON_DUPLICATE` for ones that currently already error r? @jdonszelmann
…t, r=JonathanBrouwer Set up API to make it possible to pass closures instead of `AttributeLint` Part of rust-lang#153099. This PR sets up the base implementations needed to remove `AttributeLintKind` entirely and migrate two variants as examples. r? @JonathanBrouwer
…-help, r=mati865 Fix conflicting deref move suggestion for LazyLock patterns fixes rust-lang#154826. Rust was suggesting *V -> V for let (v,) = *V, which then triggered a follow-up error suggesting the opposite. This patch makes that case suggest borrowing (&*V) instead. Also handles destructuring assignment separately so we don’t emit a misleading &*... fix-it there.
…e-the, r=Zalathar bootstrap.py: fix duplicated "the"
…-doc-broken-link, r=mati865 Fixed broken documentation link for method lookup in rustc_hir_typeck…
rustbot
added
A-attributes
Contributor
Author
Contributor
rust-bors
bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
rust-bors bot
pushed a commit
that referenced
this pull request
Apr 18, 2026
Rollup of 5 pull requests try-job: dist-various-1 try-job: test-various try-job: x86_64-gnu-aux try-job: x86_64-gnu-llvm-21-3 try-job: x86_64-msvc-1 try-job: aarch64-apple try-job: x86_64-mingw-1 try-job: i686-msvc-2
Contributor
Contributor
|
⌛ Testing commit 963d61f with merge 3142bea... Workflow: https://github.com/rust-lang/rust/actions/runs/24605185324 |
rust-bors bot
pushed a commit
that referenced
this pull request
Apr 18, 2026
…uwer Rollup of 5 pull requests Successful merges: - #155308 (Make `OnDuplicate::Error` the default for attributes) - #154432 (Set up API to make it possible to pass closures instead of `AttributeLint`) - #154843 ( Fix conflicting deref move suggestion for LazyLock patterns) - #155262 (bootstrap.py: fix duplicated "the") - #155478 (Fixed broken documentation link for method lookup in rustc_hir_typeck…)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
OnDuplicate::Errorthe default for attributes #155308 (MakeOnDuplicate::Errorthe default for attributes)AttributeLint#154432 (Set up API to make it possible to pass closures instead ofAttributeLint)r? @ghost
Create a similar rollup