Forbid check-pass/build-pass/run-pass directives in incremental tests#155589
Open
Zalathar wants to merge 4 commits intorust-lang:mainfrom
Open
Forbid check-pass/build-pass/run-pass directives in incremental tests#155589Zalathar wants to merge 4 commits intorust-lang:mainfrom
check-pass/build-pass/run-pass directives in incremental tests#155589Zalathar wants to merge 4 commits intorust-lang:mainfrom
Conversation
This is the subset of incremental tests that should continue to use `bpass` even after `cpass` is supported, because they (presumably) involve codegen.
This is the subset of incremental tests that have a FIXME to consider migrating to check-pass instead. That migration is beyond the scope of this PR, but might be attempted later.
Incremental tests that would have used the `check-pass`, `build-pass`, or `run-pass` directives should instead use a revision name starting with `cpass`/`bpass`/`rpass` as appropriate.
Collaborator
|
The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes. Some changes occurred in src/tools/compiletest cc @jieyouxu |
rustbot
added
A-compiletest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cfail/cpassrevisions tobfail/bpass#155474This PR forbids the use of
//@ check-pass,//@ build-pass, and//@ run-passdirectives in incremental tests. Tests that would have used those directives should use a revision name beginning withcpass/bpass/rpassinstead.(The
*-faildirectives are already forbidden in incremental tests.)Existing incremental tests that used the
check-passandbuild-passdirectives have been migrated. To allow migration of the check-pass tests, this PR also adds support for revision names beginning withcpass. No incremental tests were usingrun-pass.Several of the migrated
build-passtests have a FIXME indicating that they could potentially be migrated tocheck-passinstead. This PR does not perform that migration.In the future, I intend to do more cleanup of how compiletest handles pass/fail expectations, but I didn't want to cram too much into one PR.
r? jieyouxu