Skip to content

Remove a bunch of unnecessary explicit lifetimes from the ast validator#155619

Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
oli-obk:ast-validation-lifetimes
Apr 22, 2026
Merged

Remove a bunch of unnecessary explicit lifetimes from the ast validator#155619
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
oli-obk:ast-validation-lifetimes

Conversation

@oli-obk
Copy link
Copy Markdown
Contributor

@oli-obk oli-obk commented Apr 21, 2026

Noticed while fiddling with error reporting. None of the lifetimes were ever used for anything

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 21, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 21, 2026

r? @dingxiangfei2009

rustbot has assigned @dingxiangfei2009.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 72 candidates
  • Random selection from 18 candidates

@dingxiangfei2009
Copy link
Copy Markdown
Contributor

dingxiangfei2009 commented Apr 21, 2026

Sorry, I had been otherwise engaged.

@bors r+ rollup=always

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Apr 21, 2026

📌 Commit fe2e5a9 has been approved by dingxiangfei2009

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 21, 2026
jhpratt added a commit to jhpratt/rust that referenced this pull request Apr 22, 2026
…r=dingxiangfei2009

Remove a bunch of unnecessary explicit lifetimes from the ast validator

Noticed while fiddling with error reporting. None of the lifetimes were ever used for anything
rust-bors Bot pushed a commit that referenced this pull request Apr 22, 2026
Rollup of 7 pull requests

Successful merges:

 - #155589 (Forbid `check-pass`/`build-pass`/`run-pass` directives in incremental tests)
 - #155610 (Add missing `dyn` keyword to `trait_alias` page of the Unstable Book)
 - #155615 (test cleanups for `ui/derives` and `ui/deriving`)
 - #154874 (Fix ICE for inherited const conditions on const closures)
 - #155605 (std: Update support for `wasm32-wasip3`)
 - #155613 (c-variadic: tweak `std` docs)
 - #155619 (Remove a bunch of unnecessary explicit lifetimes from the ast validator)
rust-timer added a commit that referenced this pull request Apr 22, 2026
Rollup merge of #155619 - oli-obk:ast-validation-lifetimes, r=dingxiangfei2009

Remove a bunch of unnecessary explicit lifetimes from the ast validator

Noticed while fiddling with error reporting. None of the lifetimes were ever used for anything
@rust-bors rust-bors Bot merged commit 6fa2b1d into rust-lang:main Apr 22, 2026
11 checks passed
@rustbot rustbot added this to the 1.97.0 milestone Apr 22, 2026
github-actions Bot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Apr 22, 2026
Rollup of 7 pull requests

Successful merges:

 - rust-lang/rust#155589 (Forbid `check-pass`/`build-pass`/`run-pass` directives in incremental tests)
 - rust-lang/rust#155610 (Add missing `dyn` keyword to `trait_alias` page of the Unstable Book)
 - rust-lang/rust#155615 (test cleanups for `ui/derives` and `ui/deriving`)
 - rust-lang/rust#154874 (Fix ICE for inherited const conditions on const closures)
 - rust-lang/rust#155605 (std: Update support for `wasm32-wasip3`)
 - rust-lang/rust#155613 (c-variadic: tweak `std` docs)
 - rust-lang/rust#155619 (Remove a bunch of unnecessary explicit lifetimes from the ast validator)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants