Add temporary scope to assert_eq and assert_ne#155739
Add temporary scope to assert_eq and assert_ne#155739Voultapher wants to merge 1 commit intorust-lang:mainfrom
Conversation
This is a follow-up to rust-lang#155431
|
r? @joboet rustbot has assigned @joboet. Use Why was this reviewer chosen?The reviewer was selected based on:
|
|
r? @Amanieu |
|
This constitutes a desired breaking library change as per #154406 (comment). Will need a crater run. |
|
@bors try |
This comment has been minimized.
This comment has been minimized.
…<try> Add temporary scope to assert_eq and assert_ne
|
@craterbot test |
|
🚨 Error: failed to parse the command 🆘 If you have any trouble with Crater please ask in t-infra on Zulip |
|
@craterbot run mode=check |
|
🚨 Error: failed to parse the command 🆘 If you have any trouble with Crater please ask in t-infra on Zulip |
|
@craterbot check |
|
👌 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
|
@Kivooeo This can impact run time behavior via drop order, so this needs a check-and-test |
|
To be perfectly honest, I had the same initial thought, but I trusted Amanieu and did what they have been trying to do before |
This is a follow-up to #155431