Make FlatMapInPlaceVec an unsafe trait.#155951
Open
nnethercote wants to merge 1 commit intorust-lang:mainfrom
Open
Make FlatMapInPlaceVec an unsafe trait.#155951nnethercote wants to merge 1 commit intorust-lang:mainfrom
FlatMapInPlaceVec an unsafe trait.#155951nnethercote wants to merge 1 commit intorust-lang:mainfrom
Conversation
Because the memory safety of `FlatMapInPlace::flat_map_in_place` depends on `FlatMapInPlaceVec` impls behaving correctly.
rustbot
added
S-waiting-on-review
Contributor
Author
|
Thanks to @programmerjake for pointing this out. |
Kivooeo
approved these changes
Apr 29, 2026
Contributor
Author
|
@bors r=kivooeo rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
Is the "correct way to implement this trait" explained in more detail somewhere else, or is that statement just referring to the obvious limitation of "operations must be pure/idempotent outside of the expected mutation"? It seems strange to have a comment requiring you to promise that you implemented the trait correctly, but no comments about what "correctly" means for this trait. |
Contributor
Author
|
The meaning of correct operation is left implicit because it's obvious. E.g. |
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Apr 29, 2026
…ec, r=kivooeo Make `FlatMapInPlaceVec` an unsafe trait. Because the memory safety of `FlatMapInPlace::flat_map_in_place` depends on `FlatMapInPlaceVec` impls behaving correctly. r? @chenyukang
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Apr 29, 2026
…ec, r=kivooeo Make `FlatMapInPlaceVec` an unsafe trait. Because the memory safety of `FlatMapInPlace::flat_map_in_place` depends on `FlatMapInPlaceVec` impls behaving correctly. r? @chenyukang
rust-bors Bot
pushed a commit
that referenced
this pull request
Apr 29, 2026
Rollup of 9 pull requests Successful merges: - #151742 (Remove redundant information in `rustc_abi::Variants`) - #155856 (std_detect: support detecting more features on aarch64 Windows) - #155861 (Suggest `[const] Trait` bounds in more places) - #155899 (`dlltool`: Set the working directory to workaround `--temp-prefix` bug) - #155916 (Update with new LLVM 22 target for `wasm32-wali-linux-musl` target) - #155935 (remap OUT_DIR paths to fix build script path leakage in crate metadata. ) - #155950 (use the new `//@ needs-asm-mnemonic: ret` more) - #155949 (Update `opt_ast_lowering_delayed_lints` query to allow "stealing" lints, allowing to use `FnOnce` instead of `Fn`) - #155951 (Make `FlatMapInPlaceVec` an unsafe trait.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because the memory safety of
FlatMapInPlace::flat_map_in_placedepends onFlatMapInPlaceVecimpls behaving correctly.r? @chenyukang