Rollup of 4 pull requests#156111
Open
JonathanBrouwer wants to merge 18 commits intorust-lang:mainfrom
Open
Conversation
splits the large triple suggestion into three sets them to MaybeIncorrect automatically determines the required/nicest borrowing to use.
…7 instead of E0594 a set of slightly different tests showing that E0594 can be reached in some cases via autodereferencing, but also that slight variations produce E0277 instead.
added a valid example that violated the assumption in the proposed change: it is possible for a borrowee type to be a ref of it's borrowed type. removed the assumption, treated all cases appropriately.
…r printing MaybeUninit The derived implementation requires `T: Debug`, and doesn't need to.
…r=Urgau [rustdoc] Fix `doc_cfg` feature on reexports Part of rust-lang#150268. I don't mark the issue as fixed as I need to check the third case described in the issue. First commit comes from rust-lang#156020, will need to rebase this PR once the original is merged. r? @Urgau
…nathanBrouwer Fix 'assign to data in an index of' collection suggestions fixes rust-lang#150001 fixes rust-lang/rust-analyzer#16076 fixes rust-lang#134917 The issues are threefold and linked: 1. Assigning data to a ~~collection~~BTreeMap/HashMap suggests 3 solutions all marked as `MachineApplicable` 2. The suggestions are slightly wrong with regards to their borrowing needs. 3. The suggestions are not guaranteed to produce code that is valid, and suggestion number two is equivalent to an update, not an insertion. This PR: - splits the large triple suggestion into three - sets them to `MaybeIncorrect` - automatically determines the required borrowing to use. I think this solution may not be very elegant, expecially the key typechecking / borrowing part, but it works. I am however very open to any improvement/change :) edit: edited to replace 'collection' with BTreeMap/HashMap'
…RalfJung,ShoyuVanilla Rip out rustc_layout_scalar_valid_range_* attribute support And either removes tests for it or replaces the uses with pattern types. primarily fixes rust-lang#135996 fixes rust-lang#147761 fixes rust-lang#133652
…uillaumeGomez Hand-implement `impl Debug for NumBuffer` to avoid constraining `T` or printing MaybeUninit The derived implementation requires `T: Debug`, and doesn't need to.
rustbot
added
A-attributes
Contributor
Author
|
@bors r+ rollup=never p=5 |
Contributor
rust-bors
Bot
added
the
S-waiting-on-bors
rust-bors
Bot
removed
the
S-waiting-on-review
Contributor
|
⌛ Testing commit 0d98c12 with merge 818811b... Workflow: https://github.com/rust-lang/rust/actions/runs/25281924196 |
rust-bors Bot
pushed a commit
that referenced
this pull request
May 3, 2026
…uwer Rollup of 4 pull requests Successful merges: - #156073 ([rustdoc] Fix `doc_cfg` feature on reexports) - #152216 (Fix 'assign to data in an index of' collection suggestions) - #155433 (Rip out rustc_layout_scalar_valid_range_* attribute support) - #156098 (Hand-implement `impl Debug for NumBuffer` to avoid constraining `T` or printing MaybeUninit)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
doc_cfgfeature on reexports #156073 ([rustdoc] Fixdoc_cfgfeature on reexports)impl Debug for NumBufferto avoid constrainingTor printing MaybeUninit #156098 (Hand-implementimpl Debug for NumBufferto avoid constrainingTor printing MaybeUninit)r? @ghost
Create a similar rollup