Skip to content

refactor using ExprParenthesesNeeded where possible#156125

Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
GTimothy:refactor-exprparenthesesneeded
May 4, 2026
Merged

refactor using ExprParenthesesNeeded where possible#156125
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
GTimothy:refactor-exprparenthesesneeded

Conversation

@GTimothy
Copy link
Copy Markdown
Contributor

@GTimothy GTimothy commented May 3, 2026

Found multiple instances where the equivalent of ExprParenthesesNeeded was done 'manually'.
Replaced them with an ExprParenthesesNeeded::surrounding call.

@GTimothy
refactor using ExprParenthesesNeeded where possible
ed2356a 
found multiple instances where the equivalent of ExprParenthesesNeeded
was done 'manually'.
replaced them with a `ExprParenthesesNeeded::surrounding` call
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 3, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 3, 2026

r? @ShoyuVanilla

rustbot has assigned @ShoyuVanilla.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 73 candidates
  • Random selection from 22 candidates

ShoyuVanilla
ShoyuVanilla approved these changes May 4, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@ShoyuVanilla ShoyuVanilla left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

View changes since this review

@ShoyuVanilla
Copy link
Copy Markdown
Member

ShoyuVanilla commented May 4, 2026

@bors r+ rollup

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented May 4, 2026

📌 Commit ed2356a has been approved by ShoyuVanilla

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 4, 2026
@jhpratt jhpratt mentioned this pull request May 4, 2026
Merged
rust-bors Bot pushed a commit that referenced this pull request May 4, 2026
@bors
Auto merge of #156134 - jhpratt:rollup-79KaBC4, r=jhpratt
1d72d7e 
Rollup of 3 pull requests

Successful merges:

 - #156120 (Regression test for trait-system-refactor#7)
 - #156125 (refactor using ExprParenthesesNeeded where possible)
 - #156132 (More lifting tweaks)
@rust-bors rust-bors Bot merged commit 06c89cf into rust-lang:main May 4, 2026
11 checks passed
@rustbot rustbot added this to the 1.97.0 milestone May 4, 2026
rust-timer added a commit that referenced this pull request May 4, 2026
@rust-timer
Unrolled build for #156125
30c9481 
Rollup merge of #156125 - GTimothy:refactor-exprparenthesesneeded, r=ShoyuVanilla

refactor using ExprParenthesesNeeded where possible

Found multiple instances where the equivalent of `ExprParenthesesNeeded` was done 'manually'.
Replaced them with an `ExprParenthesesNeeded::surrounding` call.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShoyuVanilla ShoyuVanilla ShoyuVanilla approved these changes

Assignees

@ShoyuVanilla ShoyuVanilla

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.97.0

Development

Successfully merging this pull request may close these issues.

3 participants

@GTimothy @rustbot @ShoyuVanilla