Rollup of 3 pull requests#156134
Open
jhpratt wants to merge 9 commits intorust-lang:mainfrom
Open
Conversation
found multiple instances where the equivalent of ExprParenthesesNeeded was done 'manually'. replaced them with a `ExprParenthesesNeeded::surrounding` call
Several printing functions (e.g. `short_string`) take a liftable parameter. This commit changes the call sites to do the lifting instead. This simplifies the type signatures and puts the `lift` calls inside `tls::with` calls which is where they usually appear, and the minor cost of having more `lift` call sites.
This doesn't match any of the other uses.
Co-authored-by: lcnr <rust@lcnr.de>
Regression test for trait-system-refactor#7 Adds a regression test for [`AliasRelate` hides info in transitive cases](rust-lang/trait-system-refactor-initiative#7). The example previously errored under the new solver but compiles cleanly now thanks to eager normalization (post-rust-lang/rust#119106). Verified on both the `old` and `next` revisions. The issue body has an older TODO suggesting a goal-proving variant test; per lcnr's recent note in `#t-types/trait-system-refactor` ("this isn't an issue as we eagerly normalize"), the underlying mechanism is now resolved across both inference and goal-proving paths, so this single regression test is sufficient. Closing the upstream issue manually after merge. r? @lcnr
…eeded, r=ShoyuVanilla refactor using ExprParenthesesNeeded where possible Found multiple instances where the equivalent of `ExprParenthesesNeeded` was done 'manually'. Replaced them with an `ExprParenthesesNeeded::surrounding` call.
…=oli-obk More lifting tweaks Details in individual commits. r? @oli-obk
rustbot
added
S-waiting-on-review
Member
Author
|
@bors r+ rollup=never p=5 |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
Contributor
|
⌛ Testing commit 037e2b0 with merge 1d72d7e... Workflow: https://github.com/rust-lang/rust/actions/runs/25311614043 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
r? @ghost
Create a similar rollup