add a few new solver normalization tests#156250
Open
lqd wants to merge 4 commits intorust-lang:mainfrom
Open
Conversation
rustbot
added
the
S-waiting-on-review
rustbot
added
the
T-compiler
This comment was marked as resolved.
This comment was marked as resolved.
lcnr
reviewed
May 7, 2026
Contributor
There was a problem hiding this comment.
want to add a new "traits/normalize" folder, we already have one with the new solver but seems useful in general
can you change all tests to use #[rustc_no_implicit_bounds] 😅
the fact we have to prove MetaSized here breaks the thing we actually want to test 😅
Member
Author
done, I've also moved a handful of
I've done that for the one test where it mattered, do you want it for all tests? |
lcnr
reviewed
May 7, 2026
lcnr
reviewed
May 7, 2026
| //@ ignore-compare-mode-next-solver (explicit revisions) | ||
| //@ [next] compile-flags: -Znext-solver | ||
|
|
||
| trait Trait { |
Contributor
There was a problem hiding this comment.
can you also add #[rustc_no_implicit_bounds] to all of the other "do we try to normalize aliases tests"?
Member
Author
There was a problem hiding this comment.
alright, I've added it for the tests modified/added/moved in this PR.
There were fixed by rust-lang#140672
Another example from rust-lang/trait-system-refactor-initiative#139 and which was likely fixed by rust-lang#140672 as well.
Another example from rust-lang/trait-system-refactor-initiative#139 and which was fixed in 1.89 `nightly-2025-06-18`.
lqd
commented
May 7, 2026
| //[feature]~^^ ERROR: overflow normalizing the type alias `X2` | ||
| //[gated_old,gated_new]~^ ERROR cycle detected when expanding type alias `X1` | ||
| //[feature_old]~^^ ERROR: overflow normalizing the type alias `X2` | ||
| //[feature_new]~^^^ ERROR: type mismatch resolving `X3 normalizes-to _` |
Member
Author
There was a problem hiding this comment.
just a note of the slightly suboptimal diagnostics here compared to the old solver mentioning X1 or X2
Contributor
|
@bors r+ rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
May 7, 2026
add a few new solver normalization tests As discussed [on zulip](https://rust-lang.zulipchat.com/#narrow/channel/364551-t-types.2Ftrait-system-refactor/topic/ask.20for.20help/near/593097133), this PR adds the handful of new solver revisions and tests from rust-lang/trait-system-refactor-initiative#139. Most cases that issue mentions were already fixed by rust-lang#140672 in 1.88, and some cases, we expect, by rust-lang#155767. The issue about defaulted type parameters applies to both solvers and will be tracked in rust-lang#156271 instead. Closes rust-lang/trait-system-refactor-initiative#139. r? lcnr I'm not sure where the best place for the tests would be, do you have a better location in mind?
rust-bors Bot
pushed a commit
that referenced
this pull request
May 7, 2026
…uwer Rollup of 10 pull requests Successful merges: - #146273 (lint ImproperCTypes: refactor linting architecture (part 2)) - #154025 (Add `keepalive`, `set_keepalive` to `TcpStream` implementations) - #156024 (CFI: Fix LTO for `#![no_builtins]` crates with CFI) - #156243 (Move CrateInfo computation after codegen_crate) - #154846 (Add better default spans for the `Ty` impl of `QueryKey`) - #155220 (cg_clif: Don't show verbose run-make cmd output for passing tests) - #156204 (Implemented `PathBuf::into_string`) - #156245 (Move invocation_temp into OutputFilenames) - #156250 (add a few new solver normalization tests) - #156265 (Remove unused `ToStableHashKey` impls.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed on zulip, this PR adds the handful of new solver revisions and tests from rust-lang/trait-system-refactor-initiative#139. Most cases that issue mentions were already fixed by #140672 in 1.88, and some cases, we expect, by #155767.
The issue about defaulted type parameters applies to both solvers and will be tracked in #156271 instead.
Closes rust-lang/trait-system-refactor-initiative#139.
r? lcnr
I'm not sure where the best place for the tests would be, do you have a better location in mind?