test: Normalize -ld_classic deprecation warning#156260
Open
ZequanWu wants to merge 1 commit intorust-lang:mainfrom
Open
test: Normalize -ld_classic deprecation warning#156260ZequanWu wants to merge 1 commit intorust-lang:mainfrom
ZequanWu wants to merge 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
r? @JohnTitor rustbot has assigned @JohnTitor. Use Why was this reviewer chosen?The reviewer was selected based on:
|
JohnTitor
reviewed
May 7, 2026
| //@ compile-flags: -Copt-level=3 -Ccodegen-units=256 -Clink-arg=-ld_classic | ||
| //@ run-pass | ||
| //@ only-x86_64-apple-darwin | ||
| //@ normalize-stderr: "(?mi)^.*warning: linker stderr: ld: -ld_classic is deprecated.*\n" -> "" |
Member
There was a problem hiding this comment.
For more robust solution, I think suppressing linker_messages list would be better as the message could be changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a normalize-stderr directive to tests/ui/linking/ld64-cross-compilation.rs as the new mac os ld linker shows this warning.