Skip to content

Test EII UI tests with prefer-dynamic#156577

Open
AsakuraMizu wants to merge 1 commit into
rust-lang:mainfrom
AsakuraMizu:eii-default-dynamic
Open

Test EII UI tests with prefer-dynamic#156577
AsakuraMizu wants to merge 1 commit into
rust-lang:mainfrom
AsakuraMizu:eii-default-dynamic

Conversation

@AsakuraMizu
Copy link
Copy Markdown
Contributor

@AsakuraMizu AsakuraMizu commented May 14, 2026

Tracking issue: #125418

Remove no-prefer-dynamic from the EII UI tests now that #153648 fixed exporting EII declaration aliases from dylibs.

Fixes #151271.

Tested with:

python3 x.py test tests/ui/eii --force-rerun

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 14, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 14, 2026

r? @mejrs

rustbot has assigned @mejrs.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 73 candidates
  • Random selection from 17 candidates

Copy link
Copy Markdown
Contributor

@mejrs mejrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented May 14, 2026

📌 Commit 8f221d1 has been approved by mejrs

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 14, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request May 15, 2026
…=mejrs

Test EII UI tests with prefer-dynamic

Remove `no-prefer-dynamic` from the EII UI tests now that rust-lang#153648 fixed exporting EII declaration aliases from dylibs.

Fixes rust-lang#151271.

Tested with:

```sh
python3 x.py test tests/ui/eii --force-rerun
```
rust-bors Bot pushed a commit that referenced this pull request May 15, 2026
…uwer

Rollup of 6 pull requests

Successful merges:

 - #155360 (map_try_insert changes)
 - #156493 (actually run the temp_dir doctest)
 - #156556 (Require UTF-8 in `Utf8Pattern::StringPattern`)
 - #156565 (delegation: emit error when self type is not specified and accessed)
 - #156577 (Test EII UI tests with prefer-dynamic)
 - #156586 (Use DropCtxt::new_block and new_block_with_statements systematically.)
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request May 15, 2026
…=mejrs

Test EII UI tests with prefer-dynamic

Tracking issue: rust-lang#125418

Remove `no-prefer-dynamic` from the EII UI tests now that rust-lang#153648 fixed exporting EII declaration aliases from dylibs.

Fixes rust-lang#151271.

Tested with:

```sh
python3 x.py test tests/ui/eii --force-rerun
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Externally Implementable Items: error: undefined symbol with dynamic linking

3 participants