Support defaults for static EIIs#156583
Open
AsakuraMizu wants to merge 1 commit into
Open
Conversation
rustbot
added
the
S-waiting-on-review
rustbot
added
the
T-compiler
Collaborator
|
r? @mu001999 rustbot has assigned @mu001999. Use Why was this reviewer chosen?The reviewer was selected based on:
|
mu001999
approved these changes
May 15, 2026
Member
There was a problem hiding this comment.
LGTM, but I’ll defer to @JonathanBrouwer in case I’ve missed anything.
r? JonathanBrouwer
Collaborator
|
|
Contributor
|
I'm currently on holidays but would like to take a look, might take me a few days to get around to it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue: #125418
#154193 added EII support for statics, but left default implementations for "a followup PR". This PR implements it.
Maybe I should remove
no-prefer-dynamicif #156577 is accepted.