Revert tearing changes to dbg!#156589
Open
cuviper wants to merge 4 commits into
Open
Conversation
These are all tests from trying to fix the tear-free `dbg!`: * rust-lang#154074 * rust-lang#154994 * rust-lang#155915 These should also work as we revert to the old `dbg!`, so we should keep the tests to make sure they don't regress again. Co-authored-by: dianne <diannes.gm@gmail.com>
Collaborator
|
The Clippy subtree was changed cc @rust-lang/clippy The Miri subtree was changed cc @rust-lang/miri |
Collaborator
|
r? @mu001999 rustbot has assigned @mu001999. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Collaborator
|
|
Member
Author
|
r? libs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the primary change to
dbg!in #149869, we've been chasing a few regressions:dbg!#154074luadoes not live long enough" #154988, fixed by don't leak internal temporaries fromdbg!#154994dbg!, even on false unwind paths #155915We already reverted this once, on beta only to prevent these regressions from shipping in 1.95.
In that most recent PR, we decided that it would be better to revert
dbg!to its original state everywhere (mainand 1.96-beta), and then we can consider it from scratch later. So here I've reverted the change and its fixes, but kept the regression tests, including the pending one.cc @joboet @dianne @rust-lang/libs
@rustbot label beta-nominated