Skip to content

Revert tearing changes to dbg!#156589

Open
cuviper wants to merge 4 commits into
rust-lang:mainfrom
cuviper:revert-dbg-tearing
Open

Revert tearing changes to dbg!#156589
cuviper wants to merge 4 commits into
rust-lang:mainfrom
cuviper:revert-dbg-tearing

Conversation

@cuviper
Copy link
Copy Markdown
Member

@cuviper cuviper commented May 15, 2026

Since the primary change to dbg! in #149869, we've been chasing a few regressions:

We already reverted this once, on beta only to prevent these regressions from shipping in 1.95.

In that most recent PR, we decided that it would be better to revert dbg! to its original state everywhere (main and 1.96-beta), and then we can consider it from scratch later. So here I've reverted the change and its fixes, but kept the regression tests, including the pending one.

cc @joboet @dianne @rust-lang/libs
@rustbot label beta-nominated

cuviper and others added 4 commits May 14, 2026 15:36
…-Simulacrum"

This reverts commit 59b36a5, reversing
changes made to 197eb8c.
…Mark-Simulacrum"

This reverts commit 2a18b88, reversing
changes made to cd14b73.
…mulacrum"

This reverts commit cc666ba, reversing
changes made to 2da5959.
These are all tests from trying to fix the tear-free `dbg!`:

* rust-lang#154074
* rust-lang#154994
* rust-lang#155915

These should also work as we revert to the old `dbg!`, so we should keep
the tests to make sure they don't regress again.

Co-authored-by: dianne <diannes.gm@gmail.com>
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 15, 2026

The Clippy subtree was changed

cc @rust-lang/clippy

The Miri subtree was changed

cc @rust-lang/miri

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-clippy Relevant to the Clippy team. labels May 15, 2026
@rustbot rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels May 15, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 15, 2026

r? @mu001999

rustbot has assigned @mu001999.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 73 candidates
  • Random selection from 17 candidates

@rustbot rustbot added the beta-nominated Nominated for backporting to the compiler in the beta channel. label May 15, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 15, 2026

⚠️ Warning ⚠️

  • There are issue links (such as #123) in the commit messages of the following commits.
    Please move them to the PR description, to avoid spamming the issues with references to the commit, and so this bot can automatically canonicalize them to avoid issues with subtree.

@cuviper
Copy link
Copy Markdown
Member Author

cuviper commented May 15, 2026

r? libs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

beta-nominated Nominated for backporting to the compiler in the beta channel. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants