Rollup of 7 pull requests#156986
Open
JonathanBrouwer wants to merge 15 commits into
Open
Conversation
chore: update .fixed. fix: suggestion. Revert irrelevant changes.
…stebank Fix missing suggestion when matching `String` with `&str` Fixes rust-lang#156404 Add suggestion when matching `String` with `&str`
rustc_parse_format: improve the error diagnostic for `+` sign flag
Added a new parser diagnostic in rustc_parse_format that detects when the `+` sign flag is used without a preceding colon in a format string (e.g., `{+}`) and provides a helpful error message and suggestion to use `{:+}` instead.
r? estebank
fix issue-144595 I close the previous PR because it's too messy relevant issue:rust-lang#144595 I fix this issue by calling `look_ahead` to check if the user write a name field in the tuple struct, then try to recover after calling `parse_ty`
…eGomez rustdoc: avoid ICE when rendering body-less type consts close: rust-lang#149287
…r=JonathanBrouwer Remove unneeded `#[skip_arg]` attributes @mejrs talked with me about the `Diagnostic` rework that happened recently and suggested that the `skip_arg` might be unneeded. This PR removes all of them, except one. I'll run a perf check to see if it's actually worth keeping around or if we can just remove this attribute altogether (or eventually do the same thing in the proc-macro directly). cc @JonathanBrouwer r? ghost
…drieril add field_projections fixme haven't looked at the code in detail, but I can't see a way in which this is the correct behavior. I think ideally `try_evaluate_added_goals` just doens't return the certainty as afaik it only does so because `evaluate_added_goals_and_make_canonical_response` uses it internally r? @Nadrieril @BennoLossin
…omez,JonathanBrouwer Move check_cfg out of diagnostic attr module r? @GuillaumeGomez
rustbot
added
A-attributes
Contributor
Author
Contributor
rust-bors
Bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
May 26, 2026
Rollup of 7 pull requests try-job: dist-various-1 try-job: test-various try-job: x86_64-gnu-aux try-job: x86_64-gnu-llvm-21-3 try-job: x86_64-msvc-1 try-job: aarch64-apple try-job: x86_64-mingw-1 try-job: i686-msvc-2
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
May 26, 2026
…uwer Rollup of 7 pull requests Successful merges: - #156796 (Fix missing suggestion when matching `String` with `&str`) - #156933 (rustc_parse_format: improve the error diagnostic for `+` sign flag) - #156545 (fix issue-144595) - #156851 (rustdoc: avoid ICE when rendering body-less type consts) - #156942 (Remove unneeded `#[skip_arg]` attributes) - #156972 (add field_projections fixme) - #156975 (Move check_cfg out of diagnostic attr module)
rust-bors
Bot
added
S-waiting-on-review
Contributor
|
💔 Test for d666280 failed: CI. Failed job:
|
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Member
|
@bors retry |
rust-bors
Bot
added
S-waiting-on-bors
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
Stringwith&str#156796 (Fix missing suggestion when matchingStringwith&str)+sign flag #156933 (rustc_parse_format: improve the error diagnostic for+sign flag)#[skip_arg]attributes #156942 (Remove unneeded#[skip_arg]attributes)r? @ghost
Create a similar rollup