Move check_cfg out of diagnostic attr module#156975
Open
mejrs wants to merge 1 commit into
Open
Conversation
Collaborator
|
Some changes occurred in compiler/rustc_attr_parsing |
rustbot
added
A-attributes
GuillaumeGomez
approved these changes
May 26, 2026
Member
|
Maybe wait for @JonathanBrouwer or @jdonszelmann to also take a look but looks good to me (it's not an attribute parsing file after all). |
Contributor
|
@bors r+ rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
Contributor
|
@bors r=GuillaumeGomez,JonathanBrouwer |
Contributor
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
May 26, 2026
…omez,JonathanBrouwer Move check_cfg out of diagnostic attr module r? @GuillaumeGomez
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
May 26, 2026
…omez,JonathanBrouwer Move check_cfg out of diagnostic attr module r? @GuillaumeGomez
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
May 26, 2026
…omez,JonathanBrouwer Move check_cfg out of diagnostic attr module r? @GuillaumeGomez
rust-bors Bot
pushed a commit
that referenced
this pull request
May 26, 2026
…uwer Rollup of 7 pull requests Successful merges: - #156796 (Fix missing suggestion when matching `String` with `&str`) - #156933 (rustc_parse_format: improve the error diagnostic for `+` sign flag) - #156545 (fix issue-144595) - #156851 (rustdoc: avoid ICE when rendering body-less type consts) - #156942 (Remove unneeded `#[skip_arg]` attributes) - #156972 (add field_projections fixme) - #156975 (Move check_cfg out of diagnostic attr module)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @GuillaumeGomez