file locking: clarify that double-locking is underspecified#157046
Merged
Conversation
rustbot
added
S-waiting-on-author
Member
Author
|
@bors try jobs=*apple*,*freebsd* |
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
May 28, 2026
enable file_lock_double_unlock test on Unix targets as well try-job: *apple* try-job: *freebsd*
RalfJung
force-pushed
the
file_lock_double_unlock
branch
from
5736335 to
d80ff46
Compare
Member
Author
|
@bors try jobs=*apple*,*freebsd*,*various* |
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
May 28, 2026
enable file_lock_double_unlock test on Unix targets as well try-job: *apple* try-job: *freebsd* try-job: *various*
and make it cover the specific difference between Windows and Unix
RalfJung
force-pushed
the
file_lock_double_unlock
branch
from
d80ff46 to
a3b8240
Compare
rustbot
added
the
S-waiting-on-review
rustbot
removed
the
S-waiting-on-author
Collaborator
|
rustbot has assigned @Mark-Simulacrum. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Member
Author
|
Cc @the8472 |
RalfJung
force-pushed
the
file_lock_double_unlock
branch
from
5e4ae0b to
6397112
Compare
RalfJung
commented
May 28, 2026
| /// process, may acquire another lock. | ||
| /// If this file handle/descriptor, or a clone of it, already holds a lock, the exact behavior | ||
| /// is unspecified and platform dependent, including the possibility that it will deadlock. | ||
| /// However, if this method returns, then an exclusive lock is held. |
Member
Author
There was a problem hiding this comment.
I moved this paragraph up because it relates to the "other" from what is now the previous sentence, where previously it was a bit harder to connect the dots.
RalfJung
force-pushed
the
file_lock_double_unlock
branch
from
6397112 to
2c1d605
Compare
RalfJung
changed the title
Contributor
Member
|
@bors r+ rollup=iffy Thanks! |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
rust-bors Bot
pushed a commit
that referenced
this pull request
May 28, 2026
…uwer Rollup of 7 pull requests Successful merges: - #157046 (file locking: clarify that double-locking is underspecified) - #156401 (rustdoc: deterministic sorting for `doc_cfg` badges) - #156746 (cg_llvm: Use `LLVMDIBuilderCreateEnumeratorOfArbitraryPrecision`) - #156889 (Suggest function-local constructors without enclosing function path) - #157012 (Fix missing note of escaping `{` for braces including whitespaces) - #157056 (Update Xtensa target data layouts to match upstream LLVM) - #157062 (Add link to RFMF Sponsors page)
Member
Author
|
Does new bors support try jobs after r+? We will see. @bors try jobs=*illumos*,*solaris* |
rust-bors Bot
pushed a commit
that referenced
this pull request
May 28, 2026
file locking: clarify that double-locking is underspecified try-job: *illumos* try-job: *solaris*
This comment has been minimized.
This comment has been minimized.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 2nd commit fixes #157045 by making the docs more clear.