Rollup of 10 pull requests#157253
Closed
JonathanBrouwer wants to merge 33 commits into
Closed
Conversation
As preparation for turning #[panic_handler] from a weak lang item into an EII.
This is one of the things that made cg_clif not use cg_ssa, IIRC, so let's take the opportunities to avoid it where we can.
…hlin miri: require (almost) all 1-ZST arguments to be actually passed We can't ignore *all* of them since the compiler itself relies on non-capturing closure arguments being ignored. Fixes rust-lang/miri#4993 Cc @folkertdev since it also changes the checks for variadics.
…=jdonszelmann Check arguments of attributes where no arguments are expected This PR does the following: - Add a debug assertion to `rustc_attr_parsing`, to ensure we never forget to check the arguments of a meta item again - Removes the unused `#[derive(Clone)]` from `ArgParser` as that would break this debug assertion - **[BREAKING]** Properly check that `#[inline(always(...))]` gets no arguments - **[BREAKING]** Properly check that `#[instruction_set(arm::a32(...))]` gets no arguments - **[BREAKING]** Properly check that `#[macro_export(local_inner_macros(...))]` gets no arguments. Fixes rust-lang#154977 - **[BREAKING]** Properly check that `#[used(compiler(...))]` gets no arguments. - Properly check that `#[optimize(size(...))]` gets no arguments. - Properly check that `#[coverage(on(...))]` gets no arguments. - Properly check that `#[rustc_dump_layout(debug(...))]` gets no arguments. - Properly check that `#[rustc_abi(debug(...))]` gets no arguments. - Properly check that `#![test_runner(arg(...))]` gets no arguments. - Properly check that `#[rustc_must_implement_one_of(arg(...))]` gets no arguments. - Properly check that `#[allow_internal_unstable(arg(...))]` gets no arguments. - Properly check that `#[unstable_feature_bound(arg(...))]` gets no arguments. - Properly check that `#[rustc_allow_const_fn_unstable(arg(...))]` gets no arguments. - Properly check that `#[rustc_if_this_changed(arg(...))]` gets no arguments. - Properly check that `#[rustc_then_this_would_need(arg(...))]` gets no arguments. r? @jdonszelmann
nix: remove some unneeded variables Does not alter the semantics
…acrum Resolving Windows environment test failures This resolves an issue where the `fs::tests::test_fs_set_times follows symlink` and `fs::tests::test_fs_set_times_nofollow` tests failed locally due to permission issues in a Windows environment. The code has been modified so that these tests do not proceed if permissions are not granted. Since these tests can be passed with the necessary permissions via CI before merging, I believe it is appropriate for them to pass locally due to permission issues rather than fail. Close rust-lang#156558
…dows-clone, r=Mark-Simulacrum Don't drop uninit memory when `MapWindows::clone` panics Fixes rust-lang#156501, using the approach suggested in @bjorn3's comment rust-lang#156517 (comment)
…ts, r=jdonszelmann Add `#[unsafe_eii]` to unsafe EII UI tests Tracking issue: rust-lang#125418 Add UI test coverage for unsafe implementations of declarations created with `#[unsafe_eii]`.
…mann Use #[panic_handler] rather than #[lang = "panic_impl"] As preparation for turning #[panic_handler] from a weak lang item into an EII. r? @jdonszelmann
…dianqk cg_ssa: a bit less `immediate_or_packed_pair` This is one of the things that made cg_clif not use cg_ssa, IIRC, so let's take the opportunities to avoid it where we can. r? codegen
…ation-fix, r=petrochenkov Trace `?id.local_def_index` instead of `id` in `def_path_hash` Trace `local_def_index` instead of `LocalDefId` in `def_path_hash`, as latter causes errors (previous version of this function accepted `DefIndex`). Fixes rust-lang#157238. r? @petrochenkov
…ges, r=Urgau Tune backport Zulip messages Asked in triagebot#2407 In the zulip message that opens a backport poll, adds a suggestion about the correct triagebot syntax to approve/decline a backport to avoid ambiguity and typos Thanks for a review r? @Urgau
rustbot
added
A-attributes
Contributor
Author
Contributor
rust-bors
Bot
added
S-waiting-on-bors
rust-bors Bot
pushed a commit
that referenced
this pull request
Jun 1, 2026
Rollup of 10 pull requests try-job: dist-various-1 try-job: test-various try-job: x86_64-gnu-aux try-job: x86_64-gnu-llvm-21-3 try-job: x86_64-msvc-1 try-job: aarch64-apple try-job: x86_64-mingw-1 try-job: i686-msvc-2
Contributor
|
⌛ Trying commit a88c9f0 with merge e4ca3ff… To cancel the try build, run the command Workflow: https://github.com/rust-lang/rust/actions/runs/26760469074 |
rust-bors
Bot
added
S-waiting-on-author
Contributor
|
This pull request was unapproved due to being closed. |
Contributor
Author
|
@bors try cancel |
Contributor
|
Try build cancelled. Cancelled workflows: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
MapWindows::clonepanics #156588 (Don't drop uninit memory whenMapWindows::clonepanics)#[unsafe_eii]to unsafe EII UI tests #156817 (Add#[unsafe_eii]to unsafe EII UI tests)immediate_or_packed_pair#157220 (cg_ssa: a bit lessimmediate_or_packed_pair)?id.local_def_indexinstead ofidindef_path_hash#157241 (Trace?id.local_def_indexinstead ofidindef_path_hash)r? @ghost
Create a similar rollup