Fix missing word in the lifetime guide. #15817
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The existing wording is correct and matches usage in other languages. |
Contributor
|
If we were to expand this, I think "temporary variable" would be the most correct thing, since e.g. |
Contributor
|
If we're fine with the term "rvalue" we should be fine with the term "temporary". |
Contributor
|
I wasn't arguing either way, just pointing out the correct expansion. |
Author
|
Ah, I see. Temporary is used as a noun. I thought it was used as an adjective and that it was missing a noun. I think it's a bit confusing for newcomers, since this is one of the rare times this word is used. |
Member
|
Closing due to inactivity, but feel free to reopen with comments addressed! |
flip1995
added a commit
to flip1995/rust
that referenced
this pull request
Oct 31, 2025
rust-lang#15817) When matched against `Result` with copyable `Ok` variant, uncopyable scrutinee won't actually be moved. But `manual_unwrap_or`/`manual_unwrap_or_default` will force it to move, which can cause problem if scrutinee is used later. Fixes rust-lang/rust-clippy#15807 changelog: [`manual_unwrap_or`]: don't lint if not safe to move scrutinee changelog: [`manual_unwrap_or_default`]: don't lint if not safe to move scrutinee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was reading the lifetime guide and noticed that a word was missing from the sentence. I'm not sure if
structis the best word to describe what's happening here, let me know if you want something else.