borrowck: Introduce BlameConstraint::to_obligation_cause_from_path()#158624
Open
Enselic wants to merge 1 commit into
Open
borrowck: Introduce BlameConstraint::to_obligation_cause_from_path()#158624Enselic wants to merge 1 commit into
Enselic wants to merge 1 commit into
Conversation
Before this commit, `BlameConstraint` is a bit hard to understand at first, because of its `ObligationCause` field. In practice, `BlameConstraint` is just a slimmed down version of an `OutlivesConstraint` from `Vec<OutlivesConstraint>`. The artificial `ObligationCause` is only needed in one place. Rather than having that exception polute the lower level analysis, bubble it up as much as we can. That way, it becomes clearer what `BlameConstraint` actually is. For reference, `ObligationCause` was introdued by 93ab12e, but the codebase looked quite different back then.
Collaborator
|
r? @JohnTitor rustbot has assigned @JohnTitor. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this commit,
BlameConstraintis a bit hard to understand at first, because of itsObligationCausefield. In practice,BlameConstraintis just a slimmed down version of anOutlivesConstraintfromVec<OutlivesConstraint>.The artificial
ObligationCauseis only needed in one place. Rather than having that exception polute the lower level analysis, bubble it up as much as we can. That way, it becomes clearer whatBlameConstraintactually is.For reference,
ObligationCausewas introdued by #89249, but the codebase looked quite different back then.This takes us one step closer (this is commit 1 of 4) towards the end result illustrated in #158623.
Notes
I have removed the comment
because I think this existing comment is sufficient: