Skip to content

Add codegen test for Result is_ok unwrap#158965

Open
amirHdev wants to merge 1 commit into
rust-lang:mainfrom
amirHdev:add-codegen-test-result-is-ok-unwrap
Open

Add codegen test for Result is_ok unwrap#158965
amirHdev wants to merge 1 commit into
rust-lang:mainfrom
amirHdev:add-codegen-test-result-is-ok-unwrap

Conversation

@amirHdev

@amirHdev amirHdev commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Closes #85771

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 8, 2026
@rustbot

rustbot commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator

r? @nnethercote

rustbot has assigned @nnethercote.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 75 candidates
  • Random selection from 18 candidates

Signed-off-by: Amirhossein Akhlaghpour <m9.akhlaghpoor@gmail.com>
@amirHdev amirHdev force-pushed the add-codegen-test-result-is-ok-unwrap branch from c19e209 to 8bb04f6 Compare July 8, 2026 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

if Result::is_ok() followed immediately by Result::unwrap() fails to optimize out the second err check

3 participants