rerun in original typing mode if we meet any opaques in post analysis

[adwinwhite]

When the rerun condition is OpaqueInStorage and typing mode is PostAnalysis/Codegen, we do rerun the evaluation in original typing mode.
It's strange that we don't do the same when the rerun condition is OpaqueInStorageOrAnyOpaqueHasInferAsHidden.

This fixes an ICE when building cargo with the next solver.

r? @jdonszelmann
cc @lcnr

[adwinwhite]

@bors try @rust-timer queue

[rust-bors]

☀️ Try build successful (CI)
Build commit: 82f26fd (82f26fd08b92a1294f398b6e087af155ac598ad0)
Base parent: 14cae68 (14cae681329a63c622a6e1fbe1d30f9374bc51d8)

[rust-timer]

Finished benchmarking commit (82f26fd): comparison URL.

Overall result: ❌ regressions - no action needed

Benchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up.

@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.5%	[0.2%, 0.8%]	4
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary -2.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.8%	[-2.8%, -2.8%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.8%	[-2.8%, -2.8%]	1

Cycles

Results (secondary 1.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.8%	[2.5%, 3.3%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.4%	[-3.4%, -3.4%]	1
All ❌✅ (primary)	-	-	0

Binary size

Results (primary 0.1%, secondary 0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.1%	[0.0%, 0.1%]	50
Regressions ❌ (secondary)	0.1%	[0.0%, 0.1%]	23
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.1%	[0.0%, 0.1%]	50

Bootstrap: 488.761s -> 488.757s (-0.00%)
Artifact size: 388.78 MiB -> 388.85 MiB (0.02%)

[rustbot]

jdonszelmann is currently at their maximum review capacity.
They may take a while to respond.

[rust-log-analyzer]

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

.................................................. (50/144)
..................F............................... (100/144)
............................................       (144/144)

======== tests/rustdoc-gui/pocket-menu.goml ========

[ERROR] line 22: `rustdoc-toolbar .settings-menu .popover` not found: for command `assert-css: ("rustdoc-toolbar .settings-menu .popover", {"display": "block"})`
    at <file:///checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-gui/doc/test_docs/index.html?search=test#attribute-docs>


<= doc-ui tests done: 143 succeeded, 1 failed, 0 filtered out

Error: ()