Small cleanups to the incr comp session code#159000
Open
bjorn3 wants to merge 2 commits into
Open
Conversation
Previously we would still try to rename the incr comp session dir after deleting it.
In both cases the incr comp session dir should no longer be accessed.
rustbot
added
S-waiting-on-review
Collaborator
|
r? @mejrs rustbot has assigned @mejrs. Use Why was this reviewer chosen?The reviewer was selected based on:
|
bjorn3
commented
Jul 9, 2026
| sess.finalize_incr_comp_session(); | ||
| let _ = garbage_collect_session_directories(sess, &incr_comp_session_dir); | ||
| return; | ||
| } |
Member
Author
There was a problem hiding this comment.
Alternatively it may be possible to remove this entire branch. It looks like there is an abort_if_errors() before finalize_session_directory() in rustc_interface with no errors emitted in between. Previously this code path was broken already.
bjorn3
commented
Jul 9, 2026
| // This unlocks the directory | ||
| sess.finalize_incr_comp_session(); | ||
|
|
||
| let _ = garbage_collect_session_directories(sess, &new_path); |
Member
Author
There was a problem hiding this comment.
This will now GC the incr comp session dir if the rename failed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while working on rust-lang/compiler-team#908. I'm working on some more significant changes, but will leave those to a followup PR.