Implement "low priority impls"#159003
Draft
WaffleLapkin wants to merge 14 commits into
Draft
Conversation
There is only one place where `SourceKindSubdiag` is used without `SourceKindMultiSuggestion`; it doesn't seem useful to distinguish between them (I have no idea what either of the names means tbh)
This makes it clear that (what used to be called) `GenericLabel` and other generic variants are related -- the latter are suggestions, which can sometimes be present in *addition* to the label. Although this mainly helps future cleanups.
This simplifies things a bunch, as we don't need any mutable state to track subdiagnostics now. Also, this makes it clearer which diagnostics are possible.
…y referencing error Without this change `tests/ui/async-await/async-closures/is-not-fn.rs` ICEing when constructing proof tree, supposedly to check if an infer var is referenced in a goal...
rustbot
added
A-attributes
WaffleLapkin
added
needs-fcp
This comment has been minimized.
This comment has been minimized.
WaffleLapkin
force-pushed
the
low-prio-impls
branch
from
2028b10 to
05be60e
Compare
This comment has been minimized.
This comment has been minimized.
WaffleLapkin
force-pushed
the
low-prio-impls
branch
from
05be60e to
23a1336
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @lcnr
Based on #159002