Skip to content

fix process-panic-after-fork on some Linux#159009

Open
llogiq wants to merge 1 commit into
rust-lang:mainfrom
llogiq:fix-process-panic-after-fork
Open

fix process-panic-after-fork on some Linux#159009
llogiq wants to merge 1 commit into
rust-lang:mainfrom
llogiq:fix-process-panic-after-fork

Conversation

@llogiq

@llogiq llogiq commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

On an old voidlinux system I tested, the final status.signal() is Some(libc::SIGIOT), which fails the test. So I just extend the assertion to cover this case.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 9, 2026
@rustbot

rustbot commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

r? @wesleywiser

rustbot has assigned @wesleywiser.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 75 candidates
  • Random selection from 18 candidates

@bjorn3

bjorn3 commented Jul 9, 2026

Copy link
Copy Markdown
Member

Which kernel version is that?

@llogiq

llogiq commented Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

@bjorn3

$ uname -a
Linux 6.18.34_1 #1 SMP PREEMPT_DYNAMIC Mon Jun  1 22:43:42 UTC 2026 x86_64 GNU/Linux

@bjorn3

bjorn3 commented Jul 9, 2026

Copy link
Copy Markdown
Member

On Linux SIGIOT seems to be an alias for SIGABRT. At least to me that seems like the test genuinely failed as it didn't reach the explicit SIGUSR1 raise.

@llogiq

llogiq commented Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

In that case, what can I do to help debug the issue?

@bjorn3

bjorn3 commented Jul 9, 2026

Copy link
Copy Markdown
Member

Maybe try running the test in gdb with set detach-on-fork off and then check where the SIGIOT/SIGABRT happens?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants