Skip to content

intrinsic-test: run by default and raise sample-percentage to 100#159011

Open
xonx4l wants to merge 2 commits into
rust-lang:mainfrom
xonx4l:intrinsic-test-default
Open

intrinsic-test: run by default and raise sample-percentage to 100#159011
xonx4l wants to merge 2 commits into
rust-lang:mainfrom
xonx4l:intrinsic-test-default

Conversation

@xonx4l

@xonx4l xonx4l commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

This PR makes intrinsic-test run by default in x test and raise sample-percentage to 100.

r? @Kobzol

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jul 9, 2026
@rustbot

rustbot commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

Kobzol is not on the review rotation at the moment.
They may take a while to respond.

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

Copy link
Copy Markdown
Collaborator

The job aarch64-gnu-llvm-21-2 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ Snapshot Summary ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
Snapshot: all_stage_1
Source: src/bootstrap/src/core/builder/tests.rs:2079
────────────────────────────────────────────────────────────────────────────────
Expression: prepare_test_config(&ctx).render_steps()
────────────────────────────────────────────────────────────────────────────────
-old snapshot
+new results
────────────┬───────────────────────────────────────────────────────────────────
   56    56 │ [build] rustc 0 <host> -> Linkchecker 1 <host>
   57    57 │ [test] link-check <host>
   58    58 │ [test] tier-check <host>
   59    59 │ [test] rustc 0 <host> -> rust-analyzer 1 <host>
         60 │+[build] rustc 0 <host> -> IntrinsicTest 1 <host>
   60    61 │ [build] rustc 0 <host> -> RustdocTheme 1 <host>
   61    62 │ [test] rustdoc-theme 1 <host>
   62    63 │ [test] compiletest-rustdoc-ui 1 <host>
   63    64 │ [build] rustc 0 <host> -> JsonDocCk 1 <host>
────────────┴───────────────────────────────────────────────────────────────────
Stopped on the first failure. Run `cargo insta test` to run all snapshots.

thread 'core::builder::tests::snapshot::test_all_stage_1' (8892) panicked at /cargo/registry/src/index.crates.io-1949cf8c6b5b557f/insta-1.47.2/src/runtime.rs:719:13:
snapshot assertion for 'all_stage_1' failed in line 2079
stack backtrace:
   0: __rustc::rust_begin_unwind
             at /rustc/0417c25868d6dfbd1c291dfeae950504faa6f790/library/std/src/panicking.rs:689:5
   1: core::panicking::panic_fmt
             at /rustc/0417c25868d6dfbd1c291dfeae950504faa6f790/library/core/src/panicking.rs:80:14
   2: <insta::runtime::SnapshotAssertionContext>::finalize
             at /cargo/registry/src/index.crates.io-1949cf8c6b5b557f/insta-1.47.2/src/runtime.rs:719:13
   3: insta::runtime::assert_snapshot
             at /cargo/registry/src/index.crates.io-1949cf8c6b5b557f/insta-1.47.2/src/runtime.rs:937:13
   4: bootstrap::core::builder::tests::snapshot::test_all_stage_1
             at ./src/core/builder/tests.rs:2079:9
   5: bootstrap::core::builder::tests::snapshot::test_all_stage_1::{closure#0}
             at ./src/core/builder/tests.rs:2077:26
   6: <bootstrap::core::builder::tests::snapshot::test_all_stage_1::{closure#0} as core::ops::function::FnOnce<()>>::call_once
             at /rustc/0417c25868d6dfbd1c291dfeae950504faa6f790/library/core/src/ops/function.rs:250:5
   7: <fn() -> core::result::Result<(), alloc::string::String> as core::ops::function::FnOnce<()>>::call_once
             at /rustc/0417c25868d6dfbd1c291dfeae950504faa6f790/library/core/src/ops/function.rs:250:5
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
---- core::builder::tests::snapshot::test_all_stage_1 stdout end ----
---
##[endgroup]
##[group]Building stage1 rustbook (stage0 -> stage1, aarch64-unknown-linux-gnu)
##[endgroup]
##[group]Building stage1 rustbook (stage0 -> stage1, aarch64-unknown-linux-gnu) (continued)
Doc path: /tmp/.tmpKfChyg/build/tmp-dry-run/aarch64-unknown-linux-gnu/doc/unstable-book/index.html
Doc path: /tmp/.tmpKfChyg/build/tmp-dry-run/aarch64-unknown-linux-gnu/doc/book/index.html
##[group]Documenting stage2 book redirect pages (stage1 -> stage2, aarch64-unknown-linux-gnu)
##[endgroup]
##[group]Documenting stage2 standalone (stage1 -> stage2, aarch64-unknown-linux-gnu)
Doc path: /tmp/.tmpKfChyg/build/tmp-dry-run/aarch64-unknown-linux-gnu/doc/index.html
##[endgroup]
##[group]Documenting stage1 library{alloc, compiler_builtins, core, panic_abort, panic_unwind, proc_macro, rustc-std-workspace-core, std, std_detect, sysroot, test, unwind} in HTML format (stage1 -> stage1, aarch64-unknown-linux-gnu)
##[endgroup]
Doc path: /tmp/.tmpKfChyg/build/tmp-dry-run/aarch64-unknown-linux-gnu/doc/alloc/index.html
Documenting error index (aarch64-unknown-linux-gnu)
##[group]Building stage2 error_index_generator (stage1 -> stage2, aarch64-unknown-linux-gnu)
##[endgroup]
Doc path: /tmp/.tmpKfChyg/build/tmp-dry-run/aarch64-unknown-linux-gnu/doc/error-index.html
Doc path: /tmp/.tmpKfChyg/build/tmp-dry-run/aarch64-unknown-linux-gnu/doc/nomicon/index.html
Doc path: /tmp/.tmpKfChyg/build/tmp-dry-run/aarch64-unknown-linux-gnu/doc/reference/index.html
Doc path: /tmp/.tmpKfChyg/build/tmp-dry-run/aarch64-unknown-linux-gnu/doc/rustdoc/index.html
Doc path: /tmp/.tmpKfChyg/build/tmp-dry-run/aarch64-unknown-linux-gnu/doc/rust-by-example/index.html
Generating lint docs (aarch64-unknown-linux-gnu)
##[group]Building stage1 lint-docs (stage0 -> stage1, aarch64-unknown-linux-gnu)
##[endgroup]
##[endgroup]
##[group]Running stage2 lint-docs (stage1 -> stage2, aarch64-unknown-linux-gnu)
##[endgroup]
##[group]Building stage1 rustdoc_tool_binary (stage0 -> stage1, aarch64-unknown-linux-gnu) (continued)
Doc path: /tmp/.tmpKfChyg/build/tmp-dry-run/aarch64-unknown-linux-gnu/doc/rustc/index.html
Doc path: /tmp/.tmpKfChyg/build/tmp-dry-run/aarch64-unknown-linux-gnu/doc/cargo/index.html
Doc path: /tmp/.tmpKfChyg/build/tmp-dry-run/aarch64-unknown-linux-gnu/doc/clippy/index.html
Doc path: /tmp/.tmpKfChyg/build/tmp-dry-run/aarch64-unknown-linux-gnu/doc/embedded-book/index.html
Doc path: /tmp/.tmpKfChyg/build/tmp-dry-run/aarch64-unknown-linux-gnu/doc/edition-guide/index.html
Doc path: /tmp/.tmpKfChyg/build/tmp-dry-run/aarch64-unknown-linux-gnu/doc/style-guide/index.html
##[group]Documenting stage2 releases (stage1 -> stage2, aarch64-unknown-linux-gnu)
##[endgroup]
##[group]Building stage1 linkchecker (stage0 -> stage1, aarch64-unknown-linux-gnu)
##[endgroup]
##[group]Testing stage1 Linkcheck (aarch64-unknown-linux-gnu)
---
##[endgroup]
Generating lint docs (aarch64-unknown-linux-gnu)
##[group]Running stage2 lint-docs (stage1 -> stage2, aarch64-unknown-linux-gnu)
##[endgroup]
Doc path: /tmp/.tmpKfChyg/build/tmp-dry-run/aarch64-unknown-linux-gnu/doc/rustc/index.html
##[group]Testing stage1 stdarch-verify (aarch64-unknown-linux-gnu)
##[endgroup]
##[group]Building stage1 intrinsic-test (stage0 -> stage1, aarch64-unknown-linux-gnu)
##[endgroup]
Skipping Suite(test::tests/rustdoc-js-std) because it is excluded
---
##[endgroup]
##[group]Testing stage2 with compiletest suite=rustdoc-json mode=rustdoc-json (aarch64-unknown-linux-gnu)
##[endgroup]
##[group]Documenting stage2 compiler{rustc-main, rustc_abi, rustc_arena, rustc_ast, rustc_ast_ir, rustc_ast_lowering, rustc_ast_passes, rustc_ast_pretty, rustc_attr_parsing, rustc_baked_icu_data, rustc_borrowck, rustc_builtin_macros, rustc_codegen_llvm, rustc_codegen_ssa, rustc_const_eval, rustc_data_structures, rustc_driver, rustc_driver_impl, rustc_error_codes, rustc_error_messages, rustc_errors, rustc_expand, rustc_feature, rustc_fs_util, rustc_graphviz, rustc_hashes, rustc_hir, rustc_hir_analysis, rustc_hir_id, rustc_hir_pretty, rustc_hir_typeck, rustc_incremental, rustc_index, rustc_index_macros, rustc_infer, rustc_interface, rustc_lexer, rustc_lint, rustc_lint_defs, rustc_llvm, rustc_log, rustc_macros, rustc_metadata, rustc_middle, rustc_mir_build, rustc_mir_dataflow, rustc_mir_transform, rustc_monomorphize, rustc_next_trait_solver, rustc_parse, rustc_parse_format, rustc_passes, rustc_pattern_analysis, rustc_privacy, rustc_proc_macro, rustc_public, rustc_public_bridge, rustc_query_impl, rustc_resolve, rustc_sanitizers, rustc_serialize, rustc_session, rustc_span, rustc_symbol_mangling, rustc_target, rustc_thread_pool, rustc_trait_selection, rustc_traits, rustc_transmute, rustc_ty_utils, rustc_type_ir, rustc_type_ir_macros, rustc_windows_rc} (stage1 -> stage2, aarch64-unknown-linux-gnu)
Doc path: /tmp/.tmpKfChyg/build/tmp-dry-run/aarch64-unknown-linux-gnu/compiler-doc/rustc_main/index.html
##[endgroup]
##[group]Building stage1 html-checker (stage0 -> stage1, aarch64-unknown-linux-gnu)
##[endgroup]
##[group]Testing stage1 rust-installer (aarch64-unknown-linux-gnu)
##[endgroup]
---
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ Snapshot Summary ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
Snapshot: all_stage_2
Source: src/bootstrap/src/core/builder/tests.rs:2256
────────────────────────────────────────────────────────────────────────────────
Expression: prepare_test_config(&ctx).stage(2).render_steps()
────────────────────────────────────────────────────────────────────────────────
-old snapshot
+new results
────────────┬───────────────────────────────────────────────────────────────────
   61    61 │ [test] tier-check <host>
   62    62 │ [test] rustc 1 <host> -> rust-analyzer 2 <host>
   63    63 │ [doc] rustc (book) <host>
   64    64 │ [test] rustc 1 <host> -> lint-docs 2 <host>
         65 │+[build] rustc 0 <host> -> IntrinsicTest 1 <host>
   65    66 │ [build] rustc 0 <host> -> RustdocTheme 1 <host>
   66    67 │ [test] rustdoc-theme 2 <host>
   67    68 │ [test] compiletest-rustdoc-ui 2 <host>
   68    69 │ [build] rustc 0 <host> -> JsonDocCk 1 <host>
────────────┴───────────────────────────────────────────────────────────────────
Stopped on the first failure. Run `cargo insta test` to run all snapshots.

thread 'core::builder::tests::snapshot::test_all_stage_2' (8981) panicked at /cargo/registry/src/index.crates.io-1949cf8c6b5b557f/insta-1.47.2/src/runtime.rs:719:13:
snapshot assertion for 'all_stage_2' failed in line 2256
stack backtrace:
   0: __rustc::rust_begin_unwind
             at /rustc/0417c25868d6dfbd1c291dfeae950504faa6f790/library/std/src/panicking.rs:689:5
   1: core::panicking::panic_fmt
             at /rustc/0417c25868d6dfbd1c291dfeae950504faa6f790/library/core/src/panicking.rs:80:14
   2: <insta::runtime::SnapshotAssertionContext>::finalize
             at /cargo/registry/src/index.crates.io-1949cf8c6b5b557f/insta-1.47.2/src/runtime.rs:719:13
   3: insta::runtime::assert_snapshot
             at /cargo/registry/src/index.crates.io-1949cf8c6b5b557f/insta-1.47.2/src/runtime.rs:937:13
   4: bootstrap::core::builder::tests::snapshot::test_all_stage_2
             at ./src/core/builder/tests.rs:2256:9
   5: bootstrap::core::builder::tests::snapshot::test_all_stage_2::{closure#0}
             at ./src/core/builder/tests.rs:2254:26
   6: <bootstrap::core::builder::tests::snapshot::test_all_stage_2::{closure#0} as core::ops::function::FnOnce<()>>::call_once
             at /rustc/0417c25868d6dfbd1c291dfeae950504faa6f790/library/core/src/ops/function.rs:250:5
   7: <fn() -> core::result::Result<(), alloc::string::String> as core::ops::function::FnOnce<()>>::call_once
             at /rustc/0417c25868d6dfbd1c291dfeae950504faa6f790/library/core/src/ops/function.rs:250:5
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
---- core::builder::tests::snapshot::test_all_stage_2 stdout end ----

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants