[rustdoc] Do not take doc(cfg()) into account when filtering doctests#159014
Open
GuillaumeGomez wants to merge 3 commits into
Open
[rustdoc] Do not take doc(cfg()) into account when filtering doctests#159014GuillaumeGomez wants to merge 3 commits into
doc(cfg()) into account when filtering doctests#159014GuillaumeGomez wants to merge 3 commits into
Conversation
rustbot
added
A-run-make
This comment has been minimized.
This comment has been minimized.
Member
Author
|
And now it fails because we (doc) inlined some functions. Fixing that then. :) |
rustbot
added
O-wasi
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
doc-cfg-filter-doctest
branch
from
f5059c8 to
062cfea
Compare
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
doc-cfg-filter-doctest
branch
from
062cfea to
1d5692c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #147033.
Because it was using the
extract_cfg_from_attrscommon function, it was taking into account thedoc(cfg())attributes the same as if they were acfg.I didn't mark this PR as "fix" because I didn't handle the case of the doctest not being marked as ignored because I'm not sure if we should revisit the fact that we ignore these doctests or if we should just mark them as ignored (because of
target_feature(enable = "...")).Setting @fmease as reviewer as they are likely the only one with context about this issue. 😆
r? @fmease