Don't target synthetic APIT params in lifetime suggestion#159017
Open
ozankenangungor wants to merge 1 commit into
Open
Don't target synthetic APIT params in lifetime suggestion#159017ozankenangungor wants to merge 1 commit into
ozankenangungor wants to merge 1 commit into
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
r? @wesleywiser rustbot has assigned @wesleywiser. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #158954
This fixes an invalid lifetime suggestion involving argument-position
impl Trait.rustc could insert the new lifetime before the
impl Traitargument, producing invalid code like'a, impl Clone. Now it introduces the lifetime on the function generics instead.This only changes the diagnostic suggestion.