Skip to content

doc: clarify attr parser APIs#159123

Open
kn1g78 wants to merge 1 commit into
rust-lang:mainfrom
kn1g78:doc/attr-parser-api
Open

doc: clarify attr parser APIs#159123
kn1g78 wants to merge 1 commit into
rust-lang:mainfrom
kn1g78:doc/attr-parser-api

Conversation

@kn1g78

@kn1g78 kn1g78 commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Follow up on #155696 by documenting the higher-level AcceptContext helpers for common argument shapes.

MetaItemParser remains the lower-level tool for attributes with custom restricted syntax. Remove the stale FIXME now that the helpers are available.

@rustbot

rustbot commented Jul 11, 2026

Copy link
Copy Markdown
Collaborator

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann, @JonathanBrouwer

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 11, 2026
@rustbot

rustbot commented Jul 11, 2026

Copy link
Copy Markdown
Collaborator

r? @oli-obk

rustbot has assigned @oli-obk.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 75 candidates
  • Random selection from 19 candidates

@mejrs mejrs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r? me

@scrabsha is this what you had in mind? :)

View changes since this review

@rustbot rustbot assigned mejrs and unassigned oli-obk Jul 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants