Remove more static mut refs from UI tests#159144
Conversation
|
Thanks for the pull request, and welcome! The Rust Project is excited to review your changes, and you should hear from @fee1-dead (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
Why was this reviewer chosen?The reviewer was selected based on:
|
There was a problem hiding this comment.
I'm not a big fan of using atomics in some of these tests that don't have threading. Some of our targets don't have atomics and this makes some tests that are otherwise applicable fail on those targets. Raw pointers could just work. Also for some threaded examples consider using thread scope.
|
Reminder, once the PR becomes ready for a review, use |
Replace additional
static mutcounters and order logs in UI tests with atomic values.This removes 11 more stale
#![allow(static_mut_refs)]allowances from tests that only need simple observable counters or drop-order logs. The tests intentionally exercisingstatic mutsemantics are left unchanged.Validation:
Result: 11 passed, 0 failed.